search

StatsHelix / demoinfo

A library to analyze CS:GO demos in C#
MIT License
321 stars 78 forks source link

FlashNadeExploded / ExplosiveNadeExploded gets called without a previous WeaponFiredEvent, when player dies before throwing. #125

Open master117 opened 6 years ago

master117 commented 6 years ago

Using the newest version Demoinfo, I found that some demos fire FlashNadeExploded before a WeaponFiredEvent with a FlashNade appears. I subscribed to both WeaponFired and FlashNadeExploded, and none of the WeaponFired calls contained a FlashNade. I do not know if this affects other grenade types as well.

Here is a sample Demo with the problem, problem occurs in round 1: https://1drv.ms/u/s!Ans7g8s_3m0Jg4oj-s9KgkIIURtt6w

master117 commented 6 years ago

This affects at least HE grenades too, the problem seems to be that dieing/getting killed with a primed nade does not lead to a weaponfired event. The nade explodes but never was thrown.

moritzuehling commented 6 years ago

This is an issue of CS:GO, not the parser, so I think I'll be closing this.

I'm not saying this isn't a problem, but I feel like we're better served with setting up a "known quirks"-page than trying to fix this in the parser - this feels like it should be handled by the consumer.

Opinions?