search

StatsHelix / demoinfo

A library to analyze CS:GO demos in C#
MIT License
321 stars 78 forks source link

fix missing players data since recent update #132

Closed akiver closed 6 years ago

akiver commented 6 years ago

Since this CSGO update http://blog.counter-strike.net/index.php/2017/11/19757/ some players were missing. The table entries loop was stopped prematurely. I tested on multiple affected demos and it's working now.

moritzuehling commented 6 years ago

Yes, we had the same issue, and the same fix works well in our internal parser, so I can confirm this works. Sadly, we can't just simply backport changes like to this repository due to licensing issues. :/

About the bug:
I have no idea why I added that break; originally to be honest. I even looked in the blame to check out when this was introduced. Turns out, the initial commit. Joy.

Lets hope it doesn't break anything, but I don't think it should. Thank you very much for investing the time in debugging this!

akiver commented 6 years ago

Thanks, it's sad that you are not allowed to make important fixes public :/

master117 commented 6 years ago

Sadly, we can't just simply backport changes like to this repository due to licensing issues. :/

What does that mean? How does this collide with the MIT license?

moritzuehling commented 6 years ago

StatsHelix is a company as well. We created demoinfo before we created the company, but now we have our own proprietary code that belongs to the company.

That is the legal side, and the reason why I don't really try to petition to be able to fix bugs here is that I simply don't have the time as well to fix every bug in this parser. The one we use internally (that I'm maintaining) is quite different and basically a improved version of this.

But yeah, if there is an important bug that I can fix I can publish it, I just need to talk to the other owners, which is a bit of a hassle - so I was very glad when akiver pushed his fix. If there had been a few reports I'd probably have fixed it.