SteffanDonal / BeatSaber-SaberTailor

A Beat Saber mod to customise the length of the sabers, as well as grip position/angle.
MIT License
3 stars 11 forks source link

Update for Beat Saber v0.12.0 #2

Closed Shadnix-was-taken closed 5 years ago

Shadnix-was-taken commented 5 years ago

Ok, I hope I get this right.

This is a pull request for my updates for the SaberTailor mod that makes it compatible with Beat Saber v0.12.0 and v0.12.0p1.

The version number needs updating. I changed it in my repository to something different so it can be identified as a forked version in the command window, if anyone in the BSMG discord support channel had ever to deal with it.

The modifications to SaberGrip and SaberTrail were pretty straight forward. Just changes to accommodate the changed game structure.

Two things regarding the changes to SaberLength:

First, I couldn't find a way to disable score submission in a normal game that would provide an acceptable user experience. I also asked about this in the BSMG discord and followed two different discussions about that topic.

So, I changed the SaberLength tweak in way that it will only work in practice mode, which doesn't submit scores. For what I understand, the new practice mode is pretty much identical to a normal game play mode, including level failed states and so on. It just adds the additional capability to change speed and starting point of a map. So it kind of serves the purpose of normal game play with disabled score submission.

The practice mode detection is implemented directly into the SaberLength tweak. I realize this isn't the most elegant solution as it doesn't provide a way to be reused for multiple tweaks. So this is a point that might need updating.

Second thing: The handle and the saber aren't different game objects anymore. Hence I changed a few things around how it modifies the saber which hopefully mimics the original intention well enough. The downside is, that it currently scales the whole saber, including the handle. But it is playable.

So, this is my first try at modding, C# and dealing with Unity, so any feedback or criticism would be appreciated.

Shadnix-was-taken commented 5 years ago

Closing this for now. Found a couple of issues that need fixing.