search

SteveEasley / pyjvcprojector

A python library for controlling a JVC Projector over a network connection.
MIT License
0 stars 1 forks source link

Remote codes not working or missing #2

Closed anupmurarka closed 3 months ago

anupmurarka commented 5 months ago

Based upon open Github issue in Home Assistant repository, three remote codes don't seem to work due to typos in codes for: REMOTE_MPC, REMOTE_PICTURE_MODE, REMOTE_SETTING_MEMORY. Also please add three missing remote codes for direct setting/lens/installation memory loading (modes 1-3).

The relevant lines to be updated/added to jvcprojector/const.py are as follows:

# update
REMOTE_MPC: Final = "73F0"
REMOTE_PICTURE_MODE: Final = "73F4"
REMOTE_SETTING_MEMORY: Final = "73D4"

# add
REMOTE_MEM_MODE1: Final = "738A"
REMOTE_MEM_MODE2: Final = "738A"
REMOTE_MEM_MODE3: Final = "738A"

Submitting PR momentarily if I can

SteveEasley commented 5 months ago

Thanks for the PR. Actually I noticed after the fact that the mode1-3 codes were wrong, so fixed them in a follow up release (v1.0.9). The HA PR for this is here https://github.com/home-assistant/core/pull/108253. Hopefully makes ity into a HA release in reasonable time.

anupmurarka commented 5 months ago

Ugh - sorry about that. I had it correct in my local test code but in my prepping of the fork and PR, I pulled the wrong changes. Thanks for fixing my blunder.