remove v11 compatible deprecations

[Stexinator]

This gets rid of some deprecations that can also be handled in v11

I think in 1 or 2 releases I will drop v11 support.

[Stexinator]

@pedroaugustobt @moliloo This can be tested. I needed to make some bigger backend changes. Tell me when you are done testing.

• [ ] Weapon attack skill handling changed -> currently selected skill is broken
• [ ] everything chat card context menu
• [ ] everything active effect
• [ ] spells and attack now respect modifiers and active effects on skills
• [ ] active effects can no longer be created
• [ ] global modifiers replace them

[Stexinator]

closes https://github.com/Stexinator/TheWitcherTRPG/issues/99 https://github.com/Stexinator/TheWitcherTRPG/issues/58

[Stexinator]

@pedroaugustobt @moliloo any news yet?

[AlexanderTheGr3at]

@pedroaugustobt @moliloo any news yet?

How can I help with this stuff?

[Stexinator]

@AlexanderTheGr3at I made a little list. You can copy it and check all of it. Additionally look into the linked stories and check if the things work

[AlexanderTheGr3at]

@AlexanderTheGr3at I made a little list. You can copy it and check all of it. Additionally look into the linked stories and check if the things work

Is there somewhere we can message like discord or something? I want to help, but want to make sure I'm doing it all right.

[Stexinator]

My discord is linked in the system

[Stexinator]

@pedroaugustobt @moliloo @AlexanderTheGr3at target is sunday again

[AlexanderTheGr3at]

@pedroaugustobt @moliloo @AlexanderTheGr3at target is sunday again

I'll check it out today.

[AlexanderTheGr3at]

• [x] Weapon attack skill handling changed -> currently selected skill is broken
• [x] everything chat card context menu
• [x] everything active effect
• [x] spells and attack now respect modifiers and active effects on skills
• [x] active effects can no longer be created
• [x] global modifiers replace them

I tested and other than having to reset some weapon skills before use all seem to be working as intended.

[Stexinator]

I had to change a major point of global modifiers. Can you test them again? Thanks

[AlexanderTheGr3at]

@Stexinator I get a large amount of errors in the log when opening the world now. It also seems now the character sheet no longer works. It won't save any of the changes I make. localhost-1717356129414.log localhost-1717356126775.log localhost-1717356185068.log localhost-1717356181902.log localhost-1717356179395.log localhost-1717356176780.log localhost-1717356174625.log localhost-1717356169670.log localhost-1717356166297.log localhost-1717356163366.log localhost-1717356160229.log localhost-1717356157007.log localhost-1717356154069.log localhost-1717356150681.log localhost-1717356148330.log localhost-1717356144812.log localhost-1717356142273.log localhost-1717356139950.log localhost-1717356135477.log localhost-1717356131701.log

https://github.com/Stexinator/TheWitcherTRPG/assets/59134326/f2c5ffa1-58c8-4e80-9aa5-fee9f6ea8e7f

[AlexanderTheGr3at]

@Stexinator

Alright tested again. It seems my one character is just messed up. Can't do anything with their sheet. I tried on another character and the Global Mods seem to apply, but when they are you can't roll any attacks. I've attached the logs and uploaded a video. I've also attached the export for the one character that's messed up now.

localhost-1717358212623.log localhost-1717358161616.log localhost-1717358239531.log fvtt-Actor-artemas-jqDRHdGk6VyBGB1W.json

[Stexinator]

Can you upload the character which cannot roll attacks? I think there is something wrong with applied status effects. They need to be a number now but there is going something wrong.

Artemas had some broken values. I added safeguards to convert them back to a valid format. The culprit was the int: 0 The error with the weapon not rolling due to global Modifier is also fixed.

Your video was very helpful. Thanks for the effort

[AlexanderTheGr3at]

Here are two character export examples of the attacks not working after applying global modifiers

fvtt-Actor-ivan-h9pbABJ5bdYQfmGc.json fvtt-Actor-sir-engelnam-of-birchroot-RQNb3oZkC0qq8XKb.json

[AlexanderTheGr3at]

@Stexinator I've also found an issue with enemy attacks. None of them seem to roll right now. I don't know if this is because of the same thing with PC attacks needing to manually change the skill or not. That doesn't seem to be an option for enemies though. localhost-1717405156458.log localhost-1717405146944.log

[Stexinator]

@Stexinator I've also found an issue with enemy attacks. None of them seem to roll right now. I don't know if this is because of the same thing with PC attacks needing to manually change the skill or not. That doesn't seem to be an option for enemies though. localhost-1717405156458.log localhost-1717405146944.log

It is the same as for PC, all weapon skills for PC and NPC need to be reset

[pedroaugustobt]

Hey, I'm testing everything within Foundry, and I came across some errors, here's a list of what happened:

• Items are not placed in diagrams, I drag the item to the diagram and do not see any error notification in the console.

• When I roll Defense (dodge, reposition, etc.), the value in the skill always has a 0 in front of the value, for example, if my Dodge skill is 3, the system calculates 1d10 + 6 (REF) + 30 (Dodge)

Until then, the global and normal effects are working, I'm still going to be testing more this week with some friends of mine and checking that there are no serious errors.

[Stexinator]

Are you on the newest version? One or two versions ago the displayed formula had an extra 0 but that is fixed already

[Stexinator]

Diagrams will be fixed in the next update, there is currently no workaround

[pedroaugustobt]

Are you on the newest version? One or two versions ago the displayed formula had an extra 0 but that is fixed already

It only works when the Display roll's details setting is checked, if it is not checked, this bug happens

[Stexinator]

Fixed in next update

[pedroaugustobt]

@Stexinator Would you prefer that I create issues with the errors I find, or can it be done here?

[Stexinator]

create issues, this PR is closed, so this is not the right place for it