allow spells to active global modifier on caster sheet

Stexinator / TheWitcherTRPG

FoundryVTT The witcher trpg system

GNU General Public License v3.0

9 stars 5 forks source link

allow spells to active global modifier on caster sheet #129

Closed Stexinator closed 3 weeks ago

Stexinator commented 3 weeks ago

closes https://github.com/Stexinator/TheWitcherTRPG/issues/114 https://github.com/Stexinator/TheWitcherTRPG/issues/131

Stexinator commented 3 weeks ago

@pedroaugustobt @moliloo @AlexanderTheGr3at I found a bug where the armor of locations are not calculated when applying damage. So releasing this fast would be nice

AlexanderTheGr3at commented 3 weeks ago

@pedroaugustobt @moliloo @AlexanderTheGr3at I found a bug where the armor of locations are not calculated when applying damage. So releasing this fast would be nice

Sorry I've been mia. Got bad medical news. I'll test today.

pedroaugustobt commented 3 weeks ago

Allow spells to active global modifier on caster sheet - OK
refactor scripts + fix location armor not applied - OK
get globalModifier from compendium when not on actor - OK
add critical wounds to context menu - Some errors:

In applyCrit.js there is an error on line 42 and 50. The error causes the damage to not be applied correctly, basically there is a missing point in derivedStats.hp -> "actor.system.derivedStatshp.value".

Stexinator commented 3 weeks ago

Fixed

pedroaugustobt commented 3 weeks ago

@Stexinator It's working!

Stexinator commented 3 weeks ago

https://github.com/Stexinator/TheWitcherTRPG/issues/131 also fixed