Automated Animations - Githubissues

Stexinator / TheWitcherTRPG

FoundryVTT The witcher trpg system

GNU General Public License v3.0

9 stars 5 forks source link

Automated Animations #149

Open pedroaugustobt opened 5 days ago

pedroaugustobt commented 5 days ago

An error is happening in a module called Automated Animations, I activated the debug and in 'attackSkill' and 'damage' it is undefined. I don't know if this error is on the system side, or on the module side, but I saw people using it normally in DnD

actorId: "QEYKEiww9PJVtyks"
alias: "Geralt de Rivia"
attackSkill: undefined
damage: undefined
extraNames: ['no-damage']
item: {name: 'no-damage'}
overrideNames: []
sceneId: "D3zNJUotc4ZKcOjr"
spell: undefined
targets: []
token: TokenDocument {name: 'Geralt de Rivia', displayName: 30, actorId: 'QEYKEiww9PJVtyks', actorLink: true, #validationFailures: {…}, …}
tokenId: "PE9RABR2mp5psViB"
workflow: ChatMessage {type: 'base', system: {…}, style: 0, timestamp: 1719182496336, #validationFailures: {…}, …}
[[Prototype]]: Object

Stexinator commented 5 days ago

As you can check here the module has specific handling for the system. The problem is that the flags were done in a way that is ill-advised following v11+. So I changed that. In the module it still checks for the old way

pedroaugustobt commented 5 days ago

I believe there are few changes, can you tell me which type of flags you changed to?

Stexinator commented 5 days ago

https://github.com/Stexinator/TheWitcherTRPG/blob/main/module/actor/mixins/itemMixin.js#L591

and they should be retrieved via

https://github.com/Stexinator/TheWitcherTRPG/blob/main/module/scripts/applyDamage.js#L46

Stexinator commented 4 days ago

@pedroaugustobt will you fix that or can I start with it?

pedroaugustobt commented 4 days ago