Stexinator / TheWitcherTRPG

FoundryVTT The witcher trpg system
GNU General Public License v3.0
10 stars 5 forks source link

Weapon Effects #94

Closed Siryphas closed 1 month ago

Siryphas commented 1 month ago

I know the damage automates the roll for Percentage based effects, like Bleed and Poison, but things like Ablation, Armor Piercing, and Improved Armor Piercing still mostly have to be handled manually. Is there any way to automate more weapon effects?

Stexinator commented 1 month ago
Siryphas commented 1 month ago

Non-Lethal would actually be very helpful. My players like to make ample use of the Teaching Mechanic. They usually do PvP for "sparing." Normally, they just do damage as normal then reset their HP and Armor back up to where it was before that match, but having weapons deal damage to Stamina would be very useful

Stexinator commented 1 month ago

Non-Lethal as a weapon ability just allows to do non-lethal attacks without penalty. So there is currently no benefit for it. Adding an apply non-lethal option to the context menu would be the way to go for your use case, but that belongs into another issue :)

Siryphas commented 1 month ago

Non-lethal damage should go to Stamina instead of HP

Stexinator commented 1 month ago

Yes, but currently you cannot do non-lethal attacks, so the bonus for non-lethal trait of weapons makes no difference.

This weapon can be used for non-lethal damage without penalty

Stexinator commented 1 month ago

@moliloo this can also be tested on the dev branch. I had to rework large chunks of the weapon automation. So its best to test the whole process also without the new attributes

Stexinator commented 1 month ago

@pedroaugustobt are you also ready to start testing?

pedroaugustobt commented 1 month ago

@pedroaugustobt are you also ready to start testing?

Of course

pedroaugustobt commented 1 month ago

@Stexinator Feedback TheWitcherTRPG - Features 1st When a Derived Stat is changed, Adrenaline resets; 2nd Critical Wounds is not working, when clicking to add the critical wound, nothing happens; 3rd Ablation and Improved Armor Piercing damage is not decreasing a monster's armor after applying damage (it only decreases if the armor is placed in the monsters' new armor tab, not the old one), but it works normally for created armor; 4th It is not possible to drag the effects of the weapon attack, it appears in the chat but I cannot drag it to the token; 5th Healing on an ally is not applied after selecting him by target.

Stexinator commented 1 month ago

3) is expected due to natural armor not ablating 4) is not yet implemented, there are other issues for it

Stexinator commented 1 month ago

1st is fixed 2nd is fixed

5th I cannot reproduce it. It heals in order selected -> targeted -> user configured. You need permissions to interact with the actor to apply the heal

moliloo commented 1 month ago

I tested the three effects you added and works fine

I see you added a select option to the effects, can you explain how this work? If you plan to add a scrip to add the effect in the token or something like this, because i dont understanded the feature Weapon Edit Weapon Chat
Stexinator commented 1 month ago

You are right, currently it only puts it out in the chat card, but in the future at least the GM should be able to apply the status from there