search

StoglRobotics / ros_team_workspace

RosTeamWorkspace is a framework for boosting collaboration in teams when developing software for robots using Robot Operating System (ROS1 and ROS2).
https://rtw.stoglrobotics.de
Apache License 2.0
90 stars 19 forks source link

Dangerous command in create-new-package.bash "rm -r git" #15

Open DaisukeUra opened 3 years ago

DaisukeUra commented 3 years ago

Hello, This software seems to make the development of ROS2 easier, so I am trying it out.

The below block asks for user information on git. https://github.com/StoglRobotics/ros_team_workspace/blob/cd83934e21e2d2a7b4f07dd52a186adb83083066/scripts/create-new-package.bash#L54-L73

However, depending on the answer, the .git directory will be deleted. This may not be a problem in most cases, but it is better to confirm if you are trying to delete an important file.

destogl commented 3 years ago

Hi @DaisukeUra thanks for the interest. You are right, I am checking this wrong! I should check if there is a git folder in the parent folder...

Thanks for this!