search

StoglRobotics / ros_team_workspace

RosTeamWorkspace is a framework for boosting collaboration in teams when developing software for robots using Robot Operating System (ROS1 and ROS2).
https://rtw.stoglrobotics.de
Apache License 2.0
88 stars 18 forks source link

setup-ros-workspace is a bit confusing #58

Closed mamueluth closed 2 years ago

mamueluth commented 2 years ago

If executing setup-ros-workspace ROS_DISTRO WS_FOLDER WS_PREFIX WS_SUFFIX one might think that a new ros-workspace with the name WS_FOLDER is created. but instead a workspace called <WS_PREFIX>_<ROS_DISTRO>_<WS_SUFFIX> is created inside the WS_FOLDER. This might be over complicated and confusing.

Suggested change with introduction of CLI would be to simplify from:

setup-ros-workspace ROS_DISTRO WS_FOLDER WS_PREFIX WS_SUFFIX

to

`setup-ros-workspace WS_FOLDER ROS_DISTRO

and create a workspace called WS_FOLDER inside current $pwd or if path like ~/ or /home/<user>/ is given, then relative to $HOME

destogl commented 2 years ago

ROS distro in workspace name was shown very useful during use since usually, one has multiple version setup in parallel. Prefixes and suffixes are also very, very useful when one is using multiple versions and multiple development stages.

Can we add both cases. You case as default and other parameters would be added with flags.

mamueluth commented 2 years ago

Done with #53