Issue when disconnecting senders and receivers

Streampunk / ledger

NMOS discovery and registration APIs

Apache License 2.0

29 stars 6 forks source link

Issue when disconnecting senders and receivers #15

Closed danickd closed 8 years ago

danickd commented 8 years ago

When a controller releases a connection it sends an empty object not a null one. Verifying for an undefined id fixes the issue

sparkpunkd commented 8 years ago

The behaviour implemented here reflects the discussion in the following two basecamp posts:

The use of { "id" : null } seems to not have been documented. I'm not sure what current practice is? I'll try to clarify with a post on basecamp before accepting this pull request.

danickd commented 8 years ago

Sounds good.

We are using a controller here and they pass an empty object that's why I had to make the change. If the spec is to change then the controller would need to be updated to reflect that.

sparkpunkd commented 8 years ago

Clarified by Andrew. It is now as implemented as an empty object {} as in this pull request and described on line 48 of the RAML spec. Merging.