Use a more logical and valid ui_bgm_id value for playing silent audio

Struggleton / TitleScreenBGM

A rust plugin for Smash Ultimate to play music on the title screen

0 stars 0 forks source link

Use a more logical and valid ui_bgm_id value for playing silent audio #6

Closed ThatNintendoNerd closed 7 months ago

ThatNintendoNerd commented 7 months ago

Currently, the hash label used to play silent audio is m21b_gaw_gamer_mom. However, this seems like an arbitrary choice and is potentially an invalid one at that, as the_csk_collection_api::play_bgm should expect a ui_bgm_id hash and not a data_name hash. A better choice of an argument would be ui_bgm_crs2_49_commonsilent_lp.

Struggleton commented 7 months ago

Didn't know that one existed - good idea! Updated in commit a75e89420aa4ed18a2e08e805004d43783c12edc