No follow up conversation in French?

[Phyks]

Hi,

I am trying to get Dicio to call a specific contact in my address book, but cannot get it to do so.

First, it is not picking the correct contact (seems it is matching by last name, while I would expect it to look by first name, since these are more probably spelled correctly by the STT). Additionally, the contact I'm trying to call has a "star" in my addressbook and therefore looks like a better candidate than anyone else.

My conversation with Dicio looks like (in French, I made translations in parenthesis) :

• appeler morgan ("call morgan")
• Dois-je appeler XXX Morgan ? (Should I call XXX Morgan ?) => Provided contact has Morgan as last name, not first name, it is not the one I'm trying to reach.
• non ("no")
• Je n'ai pas compris, pouvez-vous répéter ? ("I did not understand, can you repeat?")

Saying "no" with Dicio in English does work and it then says "ok, i'm not calling anyone". It does not work in French.

Additionally, I did not find how to go on with a different conversation to try calling the next best match in addressbook.

Thanks,

[Stypox]

I think the problem is that "non" does not match the negative sentence here. "Non suffit" would match, for example, while "non" does not at the moment. You could try to edit that file to add a ? on the last OR-word of the sentence, that is in between retour and ;, then it should be able to interpret "non" as a negative response, too.

[Phyks]

If I'm understanding the file syntax correctly, I guess this is a typo of a missing parenthesis. It should read:

util_yes_no: high
[yes] oui|(pour sûr)|certainement|ok|okay|(Vas y)|affirmatif|procéder|continue|absolument|(fais le)|confirmation;
[no] non|stop|nope|arrête|(ça suffit)|assez|négatif|(ne le fais pas)|arrêt|retour;

"ça suffit" is a French expression as a whole (English would be "that's enough"), it should not be considered as two groups of words.

[Stypox]

Oh ok, makes sense. Feel free to open a PR or just create a suggestion in #123

[Phyks]

I can confirm that "Non suffit" works, and that the first part of the issue ("no" not being handled in French) will likely be solved by #123.

However, I still cannot get Dicio to call another contact that the one it is picking by default. My conversation now looks like:

• appeler morgan ("call morgan")
• Dois-je appeler XXX Morgan ? (Should I call XXX Morgan ?) => Provided contact has Morgan as last name, not first name, it is not the one I'm trying to reach.
• non ("no")
• Ok je n'appelle personne ("ok, i'm not calling anyone").

I would have expected Dicio to be able to pick contact by first name (not only by last name) and/or offer alternatives (I have multiple contacts matching the pattern "XXX Morgan", it is however only offering me to call the first one).

[Stypox]

Yeah, the logic had a flaw in case of ties. I pushed a commit fixing this, can you confirm if what I did is correct by testing this APK? app-debug.zip

[Phyks]

It is better but not yet fully working now. It does provide me multiple alternatives although:

• it only provides contacts with "Morgan" as last name, no contact with "Morgan" as first name.
• is there a way to tell Dicio which alternative is the correct one to call? I end up manually pressing the correct entry, which is not really a good fit for a voice assistant.

Thanks

[Stypox]

I pushed another commit, 67c99563ceada178f9bbf9d92045e5c39b772a87. I hope I have implemented the second part of your suggestion well, see the screenshots. As for the first part, I don't think there is consensus on whether to give more priority to the name rather than the surname, so I'd not make changes for now. Here is a testing APK: app-debug.zip.

Referencing a contact by index in the list	Referencing a contact by name

[Phyks]

Thanks a lot for the work on this, this is indeed much better!

Regarding the first part, I understand there might not be consensus on whether first or last name should be prioritized. In my case, however, the filtering seems to be too aggressive.

My addressbook looks like (redacted names / surnames):

• Morgan YYY XXX (first_name=Morgan, pseudo=YYY, last name=XXX),
• Many other contacts with "last_name=XXX", for instance "David XXX",
• Many other contacts with "last_name=Morgan", for instance "Leo Morgan".

With the latest apk-debug.apk from this thread:

• When using "Call Morgan", I get a single hit from the contacts list which is having "Morgan" as last name, e.g. Leo Morgan (a single hit when multiple contacts match this criterion of having last_name=Morgan). _This is not the expected result for me, as I would have expected to get the full list of contacts matching (last_name=Morgan || first_name=Morgan), with ranking to be determined._

• When using "Call XXX", I get the full of contacts with last_name=XXX. This is the expected result for me.

• When using "Call YYY", I get the full list of contacts with pseudo=YYY. This is the expected result for me.

I can provide more details privately, with excerpt from the addressbook, if this can be useful.

Also, there might be a consensus to prioritize "Favorite contacts" (the one which are starred in the addressbook)?

[Stypox]

What about this? I made it so that the string matching score only depends on number of matched characters and number of subsequent matched characters, so now "X Morgan" and "YYYYY Morgan" have the same distance to "Morgan". I also made the filtering a bit less aggressive at deciding whether to call one contact right away. app-debug.zip

[Phyks]

Thanks, this works great!