search

Supergiovane / KNXUltimate

KNX IP Protocol implementation for node.js
MIT License
28 stars 9 forks source link

NPM build issue v2.1.3 #22

Closed maulik9898 closed 4 months ago

maulik9898 commented 4 months ago

Salutation the system will close the issue if you don't even says "Hello", "Hi", or something like this.

Describe the bug When I installed v 2.1.3 of knxultimate from NPM I still get errors like this

`

  > @enmatter/server@ build /home/lenovo/learning/enmatter/apps/server
  > tsc -p tsconfig.json

  src/plugins/knx/readFromKNX.ts(34,23): error TS2339: Property 'clearToSend' does not exist on type 'KNXClient'.
  src/plugins/knx/sendAllReadRequ
  src/plugins/knx/readFromKNX.ts(34,23): error TS2339: Property 'clearToSend' does not exist on type 'KNXClient'.
  src/plugins/knx/sendAllReadRequ  ✖  nx run @enmatter/server:build
  > @enmatter/server@ build /home/lenovo/learning/enmatter/apps/server
  > tsc -p tsconfig.json

  src/plugins/knx/readFromKNX.ts(34,23): error TS2339: Property 'clearToSend' does not exist on type 'KNXClient'.
  src/plugins/knx/sendAllReadRequests.ts(14,25): error TS2339: Property 'clearToSend' does not exist on type 'KNXClient'.
   ELIFECYCLE  Command failed with exit code 2.

✔ nx run web:build (6s)

`

and still get error like DPT9.001 is not valid DPT.

when I download knxultimate 2.1.3 from npm as package using npm pack knxultimate@2.1.3 I can see that in buid/dptlib/dpt9.js has Wrong ID it still DPT2.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Supergiovane commented 4 months ago

Hello. The issue has been fixed...

Cursor_e_dpt9_ts_—_KNXUltimate

From where you import knxultimate? From NPM or from gitHub release?

maulik9898 commented 4 months ago

Fron npm. In the build folder it is still showing DPT2 as id. Can you download the package as a zip from nom and check

robertsLando commented 4 months ago

@Supergiovane Seems you dind't used the usual release workflow, let me do a new release 2.1.4 and see if that works. I think you forgot to build before doing the manual release (this is automatically handled by release-it when using the automated workflow)

robertsLando commented 4 months ago

@maulik9898 Try with 2.1.4

maulik9898 commented 4 months ago

Its working now

Supergiovane commented 4 months ago

@Supergiovane Seems you dind't used the usual release workflow, let me do a new release 2.1.4 and see if that works. I think you forgot to build before doing the manual release (this is automatically handled by release-it when using the automated workflow)

I've had issues with 2FA authentication, using release-it. Maybe i've missed some steps.. Sorry maulik9898