search

Supergiovane / KNXUltimate

KNX IP Protocol implementation for node.js
MIT License
28 stars 9 forks source link

writeRaw broken with length <= 6bits #23

Closed RealByron closed 4 months ago

RealByron commented 4 months ago

Salutation Hi there, thanks a lot for this wonderful piece of code ;-)

Describe the bug short GroupValueWrite in writeRaw is not sent properly

To Reproduce simply call knxUltimateClient.on(KNXClientEvents.connected, info => { // The client is connected console.log("Connected. On Duty", info); // WARNING, THIS WILL WRITE ON YOUR KNX BUS! knxUltimateClient.writeRaw("0/1/1", Buffer.from("05", "hex"), 3); });

Expected behavior should send a effective knx frame ending with value 0x83 , but sends .... 0x80

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context A PR with the missing Math.ceil function to come now !!

Supergiovane commented 4 months ago

Thanks. I'll wait for the PR!