Suzhou-Tongyuan / jnumpy

Writing Python C extensions in Julia within 5 minutes.
MIT License
234 stars 8 forks source link

Support no-copy conversion of row major ndarray #36

Closed songjhaha closed 2 years ago

songjhaha commented 2 years ago

Here is the rule of conversion of ndarray:

codecov-commenter commented 2 years ago

Codecov Report

Merging #36 (a4df9f3) into main (7e1b5c6) will increase coverage by 0.58%. The diff coverage is 97.05%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   61.33%   61.92%   +0.58%     
==========================================
  Files          11       11              
  Lines         869      885      +16     
==========================================
+ Hits          533      548      +15     
- Misses        336      337       +1     
Impacted Files Coverage Δ
TyPython/src/CPython.jl 67.74% <ø> (ø)
TyPython/src/CPython.Julia.jl 95.06% <95.23%> (-0.26%) :arrow_down:
TyPython/src/CPython.NumPy.jl 92.77% <100.00%> (+0.87%) :arrow_up:
TyPython/src/CPython.ORM.jl 97.92% <100.00%> (-0.11%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

songjhaha commented 2 years ago

Fix https://github.com/Suzhou-Tongyuan/jnumpy/issues/35 by the way

thautwarm commented 2 years ago

Is it fine to merge now? @songjhaha

songjhaha commented 2 years ago

Is it fine to merge now? @songjhaha

fine