search

Suzhou-Tongyuan / jnumpy

Writing Python C extensions in Julia within 5 minutes.
MIT License
234 stars 8 forks source link

update flags when converting ndarray to julia Array if copy happens #68

Closed songjhaha closed 1 year ago

songjhaha commented 1 year ago

Should also update flags too

https://github.com/Suzhou-Tongyuan/jnumpy/blob/c426a0728c1f3b7c492a0fa5e2c4959acfdcecca/TyPython/src/CPython.NumPy.jl#L93-L100

songjhaha commented 1 year ago

If writable flag is False so we should copy the array, the contiguous flag could be wrong if flags are not updated.