TrinityCore - logons fail even though the password is correct

[bj21]

Certain accounts are unable to logon even after resetting the in-game password.

It turns out that

$password = $this->convertPass($username,$password);

will produce the password hash with lowercase alpha characters.

Some users have upper case alpha character in their DB password hash. I added a line to strtolower the $dbarray[0] after the slashes are stripped. As soon as I figure out git (this is my very first time on here) I'll try to submit something if it is still needed. in the meantime, adding in the following line will help correct the TrinityCore logon issue

$dbarray[0] = strtolower($dbarray[0]);

[bj21]

Here is a git diff of the password change fix for trinitycore

diff --git a/engine/core/trinity.php b/engine/core/trinity.php index 0e3853a..391ed43 100644 --- a/engine/core/trinity.php +++ b/engine/core/trinity.php @@ -228,6 +228,7 @@ class User extends SessionUser implements BaseUser { /* Retrieve password from result, strip slashes */ $dbarray = $db->getRow($result); $dbarray[0] = stripslashes($dbarray[0]);

•         $dbarray[0] = strtolower($dbarray[0]);
        $password = $this->convertPass($username,$password);
  
        /* Validate that password is correct */