search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.67k stars 3.3k forks source link

Improve test code coverage of core components #12588

Open cedricongjh opened 1 year ago

cedricongjh commented 1 year ago

Description of feature/enhancement The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

  1. Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)
  2. Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested
  3. Submit the PR, link it to this issue by starting the description with "Part of #12588"
Components: Component Assignee Codecov PR Done
AddingQuestionPanelComponent - link -
CommentEditFormComponent @HarryLu33 link https://github.com/TEAMMATES/teammates/pull/12604 ✅
CommentRowComponent @ThomasGreen123 link https://github.com/TEAMMATES/teammates/pull/12612 ✅
CommentTableComponent - link -
CommentTableModalComponent @kenneySiu link https://github.com/TEAMMATES/teammates/pull/12609 ✅
CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe @cedricongjh link1, link2, link3, link4 https://github.com/TEAMMATES/teammates/pull/12589 ✅
CopyCourseModalComponent @cedricongjh link https://github.com/TEAMMATES/teammates/pull/12590 ✅
CopySessionModalComponent @Astrid641 link https://github.com/TEAMMATES/teammates/pull/12616 ✅
CourseEditFormComponent @lunoos link https://github.com/TEAMMATES/teammates/pull/12597 ✅
DatepickerComponent @dlimyy link https://github.com/TEAMMATES/teammates/pull/12592 ✅
DatePickerFormatter @dlimyy link https://github.com/TEAMMATES/teammates/pull/12593 ✅
ErrorReportComponent @u7488099 link https://github.com/TEAMMATES/teammates/pull/12610 ✅
ExtensionConfirmModalComponent @MatheuMa link https://github.com/TEAMMATES/teammates/pull/12622 ✅
FeedbackPathPanelComponent @JYH11 link https://github.com/TEAMMATES/teammates/pull/12613 ✅
LogsHistogramComponent - link -
LogsTableComponent - link -
LogsDetails - link -
LogsLine - link -
QuestionEditForm @abaduy123 link -
QuestionResponsePanelComponent @leyguan link https://github.com/TEAMMATES/teammates/pull/12867 ✅
GqrRqgViewResponsesComponent @RohithSurya link -
GroupedResponsesComponent - link -
GrqRgqViewResponsesComponent - link -
PerQuestionViewResponsesComponent @WayyGood link -
SingleStatisticsComponent @hberehan link -
InstructorResponsesViewBase @justinsegawa link -
QuestionSubmissionFormComponent @kaioenzo link -
RecipientTypeNamePipe @ThomasGreen123 link https://github.com/TEAMMATES/teammates/pull/12626 ✅
QuestionConstraint @cedricongjh link https://github.com/TEAMMATES/teammates/pull/12747 ✅
QuestionEditAnswerForm @skylar-mo link -
QuestionEditDetailsForm @rushithapenikalapati link -
RichTextEditorComponent - link -
SessionEditForm @kenneySiu link https://github.com/TEAMMATES/teammates/pull/12627 ✅
SessionsTable - link -
StudentList @cedricongjh link #12854 ✅
ToastComponent @techMedMau link https://github.com/TEAMMATES/teammates/pull/12916 ✅
ViewResultsPanelComponent @techMedMau link https://github.com/TEAMMATES/teammates/pull/12918 ✅
VisibilityMessages - link -
VisiblityPanel @Andy-W-Developer link https://github.com/TEAMMATES/teammates/pull/12868 ✅
dlimyy commented 1 year ago

Hi, could I work on the unit tests for DatepickerComponent and DatePickerFormatter? Thanks!

cedricongjh commented 1 year ago

Hi, could I work on the unit tests for DatepickerComponent and DatePickerFormatter? Thanks!

yup sure, go ahead! thank you :D

blejkowski commented 1 year ago

May I work on the tests for the AddingQuestionPanelComponent?

cedricongjh commented 1 year ago

May I work on the tests for the AddingQuestionPanelComponent?

yes, thank you!

lunoos commented 1 year ago

Hi, i could work on test cases for CourseEditFormComponent.

HarryLu33 commented 1 year ago

Hi, may I work on test cases for CommentEditFormComponent?

ThomasGreen123 commented 1 year ago

Hi @cedricongjh , I'm new to OSS and would like to work on this as my first issue. I want to work on test cases for CommentRowComponent. May I take it?

kenneySiu commented 1 year ago

Hi is it okay if i can work on test cases for CommentTableModalComponent?

JYH11 commented 1 year ago

Hi, is it fine to work on test cases for FeedbackPathPanelComponent? Thanks!

Astrid641 commented 1 year ago

Hi, may I work on the CopySessionModalComponent? Thanks!

MatheuMa commented 1 year ago

Hey, can I work on ExtensionConfirmModalComponent?

u7632387 Workshop10 (This line is just a reference for workshop, please ignore)

Miranda-lrx commented 1 year ago

Hi, I'd like to work on adding tests for the CommentTableComponent. Thank you. My id is U7763307, Workshop 10

u7488099 commented 1 year ago

Hi, can I work on ErrorReportComponent? Thanks!

cedricongjh commented 1 year ago

Hi, I'd like to work on adding tests for the AddingQuestionPanelComponent. Thank you. My id is U7763307, Workshop 10

hey @Miranda-lrx, i think @blejkowski (do let me know if you still are) is currently working on this, do pick another component to work on, and i'll assign it to you!

u7505884 commented 1 year ago

Hello, may I work on the tests for the CommentTableComponent?

Miranda-lrx commented 1 year ago

Hi, I'd like to work on adding tests for the AddingQuestionPanelComponent. Thank you. My id is U7763307, Workshop 10

hey @Miranda-lrx, i think @blejkowski (do let me know if you still are) is currently working on this, do pick another component to work on, and i'll assign it to you!

I'd like to work on adding tests for the CommentTableComponent. Thank you. My id is U7763307, Workshop 10

Miranda-lrx commented 1 year ago

Thank you, then may I choose the CommentTableModalComponent? Sorry I didn’t notice there were someone already selected the AddingQuestion task. I am willing to help with the issue!

Josiiie @.***>于2023年10月15日 周日下午5:06写道：

Hello, may I work on the tests for the CommentTableComponent?

— Reply to this email directly, view it on GitHub https://github.com/TEAMMATES/teammates/issues/12588#issuecomment-1763286131, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBSYQZ2NKEFSC7FFKBFLOYTX7N4OLANCNFSM6AAAAAA4WD25AE . You are receiving this because you were mentioned.Message ID: @.***>

cedricongjh commented 1 year ago

Thank you, then may I choose the CommentTableModalComponent? Sorry I didn’t notice there were someone already selected the AddingQuestion task. I am willing to help with the issue!

hey @Miranda-lrx, thats taken as well, there's still LogsHistogramComponent, which i've assigned to you, do let me know if that's ok

Miranda-lrx commented 1 year ago

Yes, please!

Cedric Ong @.***>于2023年10月16日 周一下午6:42写道：

Thank you, then may I choose the CommentTableModalComponent? Sorry I didn’t notice there were someone already selected the AddingQuestion task. I am willing to help with the issue!

hey @Miranda-lrx https://github.com/Miranda-lrx, thats taken as well, there's still LogsHistogramComponent, which i've assigned to you, do let me know if that's ok

— Reply to this email directly, view it on GitHub https://github.com/TEAMMATES/teammates/issues/12588#issuecomment-1763905546, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBSYQZ2FXWN2YTHY5MWCIQLX7TQNTANCNFSM6AAAAAA4WD25AE . You are receiving this because you were mentioned.Message ID: @.***>

siruwang commented 1 year ago

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

cedricongjh commented 1 year ago

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

hey @siruwang, that has already been completed, i've assigned you LogsTableComponent if that's ok with you

nikkixiong commented 1 year ago

Hi, @cedricongjh , I'd like to work on the test of CourseRelatedInfoComponent! Thanks! u7529454

sdpunit commented 1 year ago

Hi @blejkowski are you still working on AddingQuestionPanelComponent? If not @cedricongjh is it alright if I work on these tests. Thanks!

cedricongjh commented 1 year ago

Hi @blejkowski are you still working on AddingQuestionPanelComponent? If not @cedricongjh is it alright if I work on these tests. Thanks!

hey @sdpunit let's give @blejkowski another 2 days to respond, you can go ahead with working on the tests otherwise

cedricongjh commented 1 year ago

Hi, @cedricongjh , I'd like to work on the test of CourseRelatedInfoComponent! Thanks! u7529454

hey @nikkixiong that component already has 100% code coverage, i've assigned you the LogsDetails (all 4 classes inside the file) if that's ok with you

sdpunit commented 1 year ago

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

hey @siruwang, that has already been completed, i've assigned you LogsTableComponent if that's ok with you

Sorry I had taken other issue, mb. Could you please assign this issue to others. Sorry for the inconvenience.

In that case, I can work on LogsTableComponent as well until the next two days. If that's okay @cedricongjh

cedricongjh commented 1 year ago

Hi, @cedricongjh , I'd like to work on the test code of CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe. Could you please assign them to me. My uid is u7396183, workshop 3

hey @siruwang, that has already been completed, i've assigned you LogsTableComponent if that's ok with you

Sorry I had taken other issue, mb. Could you please assign this issue to others. Sorry for the inconvenience.

In that case, I can work on LogsTableComponent as well until the next two days. If that's okay @cedricongjh

Yes, go ahead

090997 commented 1 year ago

Hi,could I work on LogsHistogramComponent and LogsTableComponent Testing?

cedricongjh commented 1 year ago

Hi,could I work on LogsHistogramComponent and LogsTableComponent Testing?

hello @090997, unfortunately these have been taken already

anjum-edge commented 1 year ago

Please test LogsTableContent again because it can contain bugs Also check AddQuestionComponent because a new part of it can be deployed and can check the issues

090997 commented 1 year ago

Hi,could I work on LogsHistogramComponent and LogsTableComponent Testing?

hello @090997, unfortunately these have been taken already

@cedricongjh Hi,Is there any other components that I can try to test?

cedricongjh commented 1 year ago

hi @090997 i've assigned you LogsLine for you to try to test

nikkixiong commented 1 year ago

@cedricongjh I already finished the LogsDetails testing and got all 100% covered on my computer, I will request for a PR soon.

ThomasGreen123 commented 1 year ago

@cedricongjh，Can try to test question-response-panel.component.ts?

cedricongjh commented 1 year ago

hey @ThomasGreen123, feel free to take AddingQuestionPanelComponent

kenneySiu commented 1 year ago

Hi @cedricongjh I would also like to take on more tests if you have any available

sdpunit commented 1 year ago

hey

hey @ThomasGreen123, feel free to take AddingQuestionPanelComponent

Hey @cedricongjh I am working on AddingQuestionPanelComponent as well, since there wasn't any response from @blejkowski. However, I am happy for @ThomasGreen123 to work on it if he submits a PR before me, I'll request one tomorrow for LogsTableComponent and AddingQuestionPanelComponent subsequently.

cedricongjh commented 1 year ago

hey

hey @ThomasGreen123, feel free to take AddingQuestionPanelComponent

Hey @cedricongjh I am working on AddingQuestionPanelComponent as well, since there wasn't any response from @blejkowski. However, I am happy for @ThomasGreen123 to work on it if he submits a PR before me, I'll request one tomorrow for LogsTableComponent and AddingQuestionPanelComponent subsequently.

ah my bad! you can take that!

@ThomasGreen123, @kenneySiu give me a moment, i'll find new components for you to work on!

cedricongjh commented 1 year ago

hey @ThomasGreen123 and @kenneySiu i've assigned new components for you to work on! thank you for taking them up

github-actions[bot] commented 11 months ago

Good First Issue - Notes for Contributors This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

sarfophil commented 11 months ago

Hello, May I work on the test for SingleStatisticsComponent?

cedricongjh commented 11 months ago

Hello, May I work on the test for SingleStatisticsComponent?

hi @sarfophil, do go ahead!

xGREGKERSEYx commented 10 months ago

Hello! Are there any open one's for Java?

cedricongjh commented 10 months ago

hi @xGREGKERSEYx, there's none open for Java at the moment, as the core team is working on migration of our Java backend

abaduy123 commented 9 months ago

hi can I work on QuestionEditForm tests if it still available

cedricongjh commented 9 months ago

hi @abaduy123 feel free to!

leyguan commented 9 months ago

hi, may I work on QuestionResponsePanelComponent?

cedricongjh commented 9 months ago

hi @leyguan, do go ahead!

Andy-W-Developer commented 8 months ago

Hey, I would like to work on VisiblityPanel, thanks!

cedricongjh commented 8 months ago

hey @Andy-W-Developer, feel free to! here's an example PR on how we are currently doing unit tests: #12863, do follow it when implementing yours