search

TEOS-10 / GSW-C

C implementation of the Thermodynamic Equation Of Seawater - 2010 (TEOS-10)
Other
18 stars 17 forks source link

nmake compatibility #39

Closed egecetin closed 3 years ago

egecetin commented 3 years ago

Changed Makefile to use the same file for make (Linux) and nmake (Windows)

Additionally gsw_check_functions.c array definitions changed because of Compiler Error C2131.

efiring commented 3 years ago

@docotak, @ocefpaf: any comments?

ocefpaf commented 3 years ago

@DocOtak, @ocefpaf: any comments?

I'm definetly not an expert on C and Windows. It would be nice to set a CI to test that compilation though. Let me see if I can make something for Linux that we can port to Windows later. (This is nor a blocker to merge this PR.)

DocOtak commented 3 years ago

I probably have a similar background re windows experience as @ocefpaf, I think we'll need to rely on contributions like this for windows support. I'd say let's get CI setup so we have some assurances that downstream projects won't break and we can merge.

ocefpaf commented 3 years ago

I'd say let's get CI setup so we have some assurances that downstream projects won't break and we can merge.

@egecetin I pushed the GitHub Action test to your branch and it is passing! Thanks!!

egecetin commented 3 years ago

I'd say let's get CI setup so we have some assurances that downstream projects won't break and we can merge.

@egecetin I pushed the GitHub Action test to your branch and it is passing! Thanks!!

Thanks for your efforts in CI which makes this PR more meaningful. I think it can be merged now safely.

efiring commented 3 years ago

Thank you!