Closed efiring closed 2 years ago
https://github.com/TEOS-10/GibbsSeaWater.jl/issues/18#issuecomment-1001223033 and https://discourse.julialang.org/t/a-weird-issue-with-julia-1-7-1-on-ubuntu-gibbsseawater-jl-package/73632 show the error for lon > 360. The gsw_saar function is only handling negative longitudes, not longitudes beyond 360. Likely fix: change
if (lon < 0.0) lon += 360.0;
to
lon = fmod(lon, 360); if (lon < 0.0) lon += 360.0;
I would be inclined to fix it first in Python and then propagate it back to here, since testing is so much easier in Python.
Closed by #47.
https://github.com/TEOS-10/GibbsSeaWater.jl/issues/18#issuecomment-1001223033 and https://discourse.julialang.org/t/a-weird-issue-with-julia-1-7-1-on-ubuntu-gibbsseawater-jl-package/73632 show the error for lon > 360. The gsw_saar function is only handling negative longitudes, not longitudes beyond 360. Likely fix: change
to
I would be inclined to fix it first in Python and then propagate it back to here, since testing is so much easier in Python.