search

TEOS-10 / GSW-C

C implementation of the Thermodynamic Equation Of Seawater - 2010 (TEOS-10)
Other
18 stars 17 forks source link

add gibbs signature #59

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

First step to fix https://github.com/TEOS-10/GSW-Python/issues/128

ocefpaf commented 1 year ago

This is just duplicating a line that is found a few lines down.

Thanks to your comment on the Python PR I think I know the path forward here. I can try it tomorrow, unless someone beats me to it.

ocefpaf commented 1 year ago

According to your comments in https://github.com/TEOS-10/GSW-Python/pull/130#issuecomment-1498655734 the changes necessary for this do belong in GSW-Python. The method for its implementation is still not clear though. If we will modify the auto-generation or patch the method_bodies.c and method_def_entries.c files. Closing this.