search

TEOS-10 / GSW-C

C implementation of the Thermodynamic Equation Of Seawater - 2010 (TEOS-10)
Other
18 stars 17 forks source link

Matlab gibbs handles more derivative combinations #61

Open efiring opened 1 year ago

efiring commented 1 year ago

The current Matlab code handles the following (ns, nt, np) argument sets to the gibbs function, that are not included in GSW-C: 030, 021, 111, 201, 120, 210, 102, 012. Evidently these are not use in any of the other functions included in GSW-C. Is there any point in adding them?

ocefpaf commented 1 year ago

Is there any point in adding them?

Asking here will only reach a subset of the users. IMO, no. But I don't have any application for those. Is there a TEOS-10 mailing list that we could ask this? Or maybe @PaulMBarker could give us some insight on what Matlab users are doing with those?

efiring commented 1 year ago

The terms that are included in the Matlab but not the Fortran or C are the 3rd order derivatives. In the Matlab they date back to at least March, 2017. I'm sure @PaulMBarker will be able to provide the background as to why they are there, and guidance as to whether we should add them.

PaulMBarker commented 1 year ago

Some of programmes are codes I wrote for myself, but have shared them through the toolbox. Also some took a huge amount of work and it seemed a shame to ignore or scrap them. I would suggest it would be more beneficial to the community to focus om adding more programmes that use or are based on the 76 term polynomial. But having said that, I am happy to see any programme translated from Matlab to C, as they may will be useful to some oceanographers and lead to advancements in the field.