search

TEOS-10 / GSW-C

C implementation of the Thermodynamic Equation Of Seawater - 2010 (TEOS-10)
Other
18 stars 17 forks source link

Meson build file? #72

Open peter-urban opened 1 month ago

peter-urban commented 1 month ago

I created a meson.build file (with tests) to more easily integrate this project with my existing projects. I was wondering if you want to add this to the main project? (It can live next to the Makefile) If so, I can work on a clean PR.

If not: feel free to reject this issue. It is no problem maintain this as separate fork.

ocefpaf commented 1 month ago

I'll defer to Eric but, IMO, I welcomed a meson build. We might as well use it in the future to build the Python extension too. My only concern is with the increased complexity. I would remove the Makefile in the future if all we need is the meson.build.

to more easily integrate this project with my existing projects.

Just out of curiosity, what are you building?

peter-urban commented 1 month ago

Just out of curiosity, what are you building?

themachinethatgoesping It's is a multibeam and singlebeam python processing library (written in c++). GSW-C is to be used for absorption computation.

We might as well use it in the future to build the Python extension too.

I am happy to contribute if you want to move in this direction . I use meson with meson-python as a build backend for my python extensions. Though I don't have experience with ufunc etc. Anyways, that's an issue for GSW-Python once this issue is discussed ;-)

efiring commented 1 month ago

I would welcome the meson build for this project, as well as the possibility of your participation in additional projects.

peter-urban commented 1 month ago

Ok, good to know! I'll prepare a PR when I find the time. (It may take a while, but it'll happen)