search

TEOS-10 / GSW-C

C implementation of the Thermodynamic Equation Of Seawater - 2010 (TEOS-10)
Other
18 stars 17 forks source link

Add gsw_sa_ct_interp and gsw_tracer_ct_interp #73

Closed mauzey1 closed 1 month ago

mauzey1 commented 1 month ago

This adds C versions of the GSW-Matlab functions gsw_SA_CT_interp and gsw_tracer_CT_interp.

I plan to add these functions to GSW-Python in a followup PR.

efiring commented 1 month ago

To be clear: if you would prefer to leave the requested change for a separate PR, I would be willing to merge the current PR first. The complexity would all come in the test implementation, not in the additional define and the matching code block in the function.

mauzey1 commented 1 month ago

@efiring I'll consider adding the new interpolation to gsw_geo_strf_dyn_height_1 in another PR.

efiring commented 1 month ago

@mauzey1 Thank you for this large contribution. I look forward to follow-ups here and in GSW-Python. Out of curiosity: what motivated you to start working on GSW?

durack1 commented 2 weeks ago

@efiring I can answer there, @mauzey1 is working with me at LLNL, and we had a small amount of project funds that could be used to attempt to bring some of the GSW-matlab functionality across to the license-free GSW variants. The aim was to tackle a number of the functions that didn't exist in license-free software, so hopefully this makes a start in that direction

efiring commented 2 weeks ago

@durack1 Thank you, it's a great start--a big contribution.

durack1 commented 2 weeks ago

@efiring that thanks should go directly to @mauzey1 - we're lucky to have him