search

TEdit / Terraria-Map-Editor

TEdit - Terraria Map Editor - TEdit is a stand alone, open source map editor for Terraria. It lets you edit maps just like (almost) paint! It also lets you change world settings (time, bosses downed etc), edit chests and change sign, make epic dungeons, castles, cities, and add rewards for your adventurers!
https://docs.binaryconstruct.com/
Other
1.6k stars 342 forks source link

TEdit4-Beta 20 for Terraria 1.4 #1182

Closed BinaryConstruct closed 4 years ago

BinaryConstruct commented 4 years ago

Running release notes for 1.4

Want to help? See Developing and Contributing to TEdit

This is BETA, use for testing and helping locate bugs and trying out new features.

Thank you all for testing, feedback and pull requests. All of the information will help this project move forward. This release should be functional and save files should not be broken. Numerous bug and crash fixes have been resolved for some long standing issues.

What's left? Check out the milestone for Journey's End: https://github.com/TEdit/Terraria-Map-Editor/milestone/10

Download

Issues

Commenting

If you have constructive feedback, such as config file edits or something that will help speed development or improve the application please leave a comment here. Things like "it didn't work" are not meant for this thread. Thanks.

Arthur-Kenichi-Condino commented 4 years ago

just read this. I wanna help though. Anything I can test for you?

tomek-i commented 4 years ago

@BinaryConstruct welcome back!

you should dev. Consider adding a few people to the repo to help you out :)

BinaryConstruct commented 4 years ago

@BinaryConstruct welcome back!

you should dev. Consider adding a few people to the repo to help you out :)

just read this. I wanna help though. Anything I can test for you? Download the beta, load worlds. Identify missing tiles, test for crashes. There will be a warning about the file footer that will be resolved with the next release.

Tile IDs for all the new tiles > id 470 to 623 are missing from the https://github.com/TEdit/Terraria-Map-Editor/blob/master/TEditXna/settings.xml file.

Anyone is free to submit a PR!

Arthur-Kenichi-Condino commented 4 years ago

I'm working on a project now, when I get it done, I'll try searching some more. But I have the beta here and the visual studio open. I tried to add try-catch but then the texture data in tiles has a argument null exception, if I remember right.

Will you make a World Save/Load V3?

I'll try to list some unknown tiles and the ids the app shows with pink squares.

theoceanmytho commented 4 years ago

is it still possible to edit worlds for doing things like getting rid of world evils/hallow? or would that brick the world as well?

theoceanmytho commented 4 years ago

answered my own question, answer's no. looking forward to the next version so i can get back to getting rid of world evil and hallow

BinaryConstruct commented 4 years ago

Beta 2 is out, it should have functional save files.

theoceanmytho commented 4 years ago

lit

On Mon, May 18, 2020, 3:07 PM BinaryConstruct notifications@github.com wrote:

Beta 2 is out, it should have functional save files.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TEdit/Terraria-Map-Editor/issues/1182#issuecomment-630380323, or unsubscribe https://github.com/notifications/unsubscribe-auth/APT4QFGIIFOA2AQTAWNTAWLRSGBOHANCNFSM4NDP43OA .

Chaox666 commented 4 years ago

I tried to change the difficulty to expert mode, but there is no expert mode in the dropdown menu. Could you add it?

theoceanmytho commented 4 years ago

Quick question, at the end of the saving process for modified worlds, it says "save creative powers..", what does it mean and on average for a large world, how long does that saving process specifically take?

On Mon, May 18, 2020, 4:13 PM Chaox666 notifications@github.com wrote:

I tried to change the difficulty to expert mode, but there is no expert mode in the dropdown menu. Could you add it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TEdit/Terraria-Map-Editor/issues/1182#issuecomment-630410630, or unsubscribe https://github.com/notifications/unsubscribe-auth/APT4QFCTZNECMHLTU5TNTRDRSGJFFANCNFSM4NDP43OA .

nosnowowie93347 commented 4 years ago

plz fix this image

nosnowowie93347 commented 4 years ago

also every time i change something and save, none of the changes are there ingame

Roxas027 commented 4 years ago

Save function doesn't work (as well as Save as) tried to save as a new map, not working, (running with and without administrator) so it's a save function problem

nosnowowie93347 commented 4 years ago

same @Roxas027

nosnowowie93347 commented 4 years ago

@BinaryConstruct please fix this and sorry for @ you but I felt you need to hear this

theoceanmytho commented 4 years ago

I have the same problem as nosnowowie, hope this gets fixed soon

theoceanmytho commented 4 years ago

@nosnowowie93347 we might have the same problem, are you stuck on "Save Creative Powers..." on the saving stage and decide to leave at that point? To further specify it's only happening to me on my main world, a large classic mode world, the problem might be in world size and/or world type, since i also have a small journey mode world and that saved all the changes i put on it in tedit without any problem

nosnowowie93347 commented 4 years ago

@theoceanmytho YES THAT IS THE PROBLEM it's that damn saving creative powers. @BinaryConstruct THAT"S WHAT'S BREAKING THE APP srry about caps just excited that SOMEONE else has this issue

nosnowowie93347 commented 4 years ago

is the developer even here to see our feedback? i hope so

nosnowowie93347 commented 4 years ago

if this brokenness is release two, I'd hate to see release 1 xD

theoceanmytho commented 4 years ago

release 1 was the version where you couldnt even load save files. i'm currently setting up at least 2 different worlds to see if it's either an issue with world size or world type, i'll let you know about the results of what im doing

theoceanmytho commented 4 years ago

ok, i think i know the problem, but i'm only about 50% or so done with the experiment, i'll have to make 3 journey mode worlds to fully gauge how bad it is, the small classic mode world has the save creative powers problem as well, update on experiment should be soon

theoceanmytho commented 4 years ago

alright, there are 2 potential reasons behind the 'save creative powers' issues. The first is the world's in classic mode. The second is that the world is hard mode, i'll need to make at least 3 worlds, all journey mode, to fully verify.

ericdallo commented 4 years ago

@theoceanmytho I have a world in pre-hardmode of medium size in classic mode with the same "Save creative Powers..." bug

theoceanmytho commented 4 years ago

I'm willing to bet that the 'save creative powers' bug is caused from the classic mode, journey mode has no quarrels with loading tedit modifications (i just use the pencil tool to draw a dirt L in the sky for modifications, if there's no L, it didn't work)

theoceanmytho commented 4 years ago

also quick update: small journey mode world is loading up tedit mods just fine, it's pre-hardmode

theoceanmytho commented 4 years ago

ok i THINK i know the problem with 'save creative powers'. It's a bug caused by 2 problems, the first one and MOST common one is the world being 'classic' mode, the second mode which i had a suspect feeling about it being something that can cause the bug, is the world being in hard mode. While i haven't tried it yet with master mode that's because i'm refusing to play master mode in any capacity without doing a playthrough with friends first. but yeah, the 'Save Creative Powers..." problem is caused by classic mode for a total game mode and hard mode being enabled, one of these individually can both cause the problem. both of them at the same time cause it as well. @BinaryConstruct @nosnowowie93347 @ericdallo hope this helps, sorry for the ping

Dcollins85 commented 4 years ago

@theoceanmytho I tried it in Master Mode and I get the same thing "Save Creative Powers..."

Chibbens commented 4 years ago

@Dcollins85 I have the same issue with Master Mode, although instead of getting stuck in "Save Creative Powers" I get stuck on "Save Bestiary".

theoceanmytho commented 4 years ago

Like i said in the previous post, for more personal reasons than anything i have no way to help you, i'm sorry if it seems selfish but i'd be happy to help you once i start a master mode playthrough to fully figure out the problem. Sorry again.

Chibbens commented 4 years ago

@theoceanmytho No worries, I'm sure the dev will patch the bug soon.

ericdallo commented 4 years ago

Just downloaded the source code and debugged it until found the problem, that is on reading the bestiary section @BinaryConstruct... Well, I never worked with C# neither .net but after removingthese lines, it seems to save the world successfully :)

I know that is not the correct way, but it seems to be a workaround, I'll try to generate a release for the other people try it too 🎉

-- Edit

Well, it seems to not fix the problem as when we load the world terraria crash :/

theoceanmytho commented 4 years ago

Odds are either tomorrow or a few days the devs' will fix it

BinaryConstruct commented 4 years ago

Rest assured I am reading these comments and will work on these issues. Please be patient, solving issues can take a while to track down all the edge cases. PRs are welcome, additionally you can view the source for other map editor/viewers to get ideas for how to fix bugs. These other projects are all going through the same changes.

schrodingerspsycho commented 4 years ago

Also - it seems that it got that problem with opening journey mode worlds, non-journey 1.4 worlds can be opened.

Edit: by further testing I can see that it's, indeed, the bestiary - fresh created worlds are opening/saving just fine, but worlds which were played in for some time isn't

Dcollins85 commented 4 years ago

@BinaryConstruct When I changed the world difficulty to Expert I got it to work. Just an FYI. I made a brand new world, didn't change the name, kept it on random for corruption/crimson, and set the world difficulty to Expert. I went in with my main character and it worked just fine. TEdit saved my changes and everything.

theoceanmytho commented 4 years ago

So the problem is, at the very least, something in the code for the bestiary.

BinaryConstruct commented 4 years ago

Beta 3 fixes bestiary. There is still the issue with special container tiles.

nosnowowie93347 commented 4 years ago

praying that beta 3 also fixed the no saving world problem

theoceanmytho commented 4 years ago

since the saving problem was caused by the bestiary it's very probable, i'll check later tonight.

theoceanmytho commented 4 years ago

'later tonight' Came alot sooner than i thought, it works just fine now, i removed corruption where i didn't want it and added a dirt border around a pylon i placed, thanks for fixing the bug

theoceanmytho commented 4 years ago

P.S. The pylons' stop working when you load into a tedit-ed world, but the fix for that is to just break them and place them back where you put them

BinaryConstruct commented 4 years ago

P.S. The pylons' stop working when you load into a tedit-ed world, but the fix for that is to just break them and place them back where you put them

This is related to #1200

nosnowowie93347 commented 4 years ago

@theoceanmytho nice. glad saving works now

nosnowowie93347 commented 4 years ago

does copy-paste schematics still work? god i hope so

theoceanmytho commented 4 years ago

havent tested it yet, i'll do it later

nosnowowie93347 commented 4 years ago

ok

nosnowowie93347 commented 4 years ago

no need to do it right away.

Tenouchi commented 4 years ago

Hello BinaryConstruct :) I just wanted to say thank you for all your hard work. I wasn't able to save my structure from my old world to my new one, but after the BETA 3 update it works! Thank you again

MHN-Hartech commented 4 years ago

Just tried to copy & paste a schematic. worked fine up until i tried to save where it was stuck at "Save Bestiary..."