search

TEdit / Terraria-Map-Editor

TEdit - Terraria Map Editor - TEdit is a stand alone, open source map editor for Terraria. It lets you edit maps just like (almost) paint! It also lets you change world settings (time, bosses downed etc), edit chests and change sign, make epic dungeons, castles, cities, and add rewards for your adventurers!
https://docs.binaryconstruct.com/
Other
1.6k stars 342 forks source link

TEdit4-Beta 20 for Terraria 1.4 #1182

Closed BinaryConstruct closed 4 years ago

BinaryConstruct commented 4 years ago

Running release notes for 1.4

Want to help? See Developing and Contributing to TEdit

This is BETA, use for testing and helping locate bugs and trying out new features.

Thank you all for testing, feedback and pull requests. All of the information will help this project move forward. This release should be functional and save files should not be broken. Numerous bug and crash fixes have been resolved for some long standing issues.

What's left? Check out the milestone for Journey's End: https://github.com/TEdit/Terraria-Map-Editor/milestone/10

Download

Issues

Commenting

If you have constructive feedback, such as config file edits or something that will help speed development or improve the application please leave a comment here. Things like "it didn't work" are not meant for this thread. Thanks.

Chibbens commented 4 years ago

@MHN-Hartech I had the same issue even after the patch, but I managed to fix it. There seems to be a bug involving special container tile entities, such as hat racks, weapon racks, etc., that somehow correlates to the "Save Bestiary" bug. The way I resolved it was going into the world on Terraria and removing the hat racks and other similar entities, saving and exiting the world, and then loading it up in TEdit. This managed to fix my issue.

BinaryConstruct commented 4 years ago

@MHN-Hartech I had the same issue even after the patch, but I managed to fix it. There seems to be a bug involving special container tile entities, such as hat racks, weapon racks, etc., that somehow correlates to the "Save Bestiary" bug. The way I resolved it was going into the world on Terraria and removing the hat racks and other similar entities, saving and exiting the world, and then loading it up in TEdit. This managed to fix my issue.

This is issue #1200, the next on the To fix list.

nosnowowie93347 commented 4 years ago

@BinaryConstruct what does the Simple Ore Generator do? I know this may not be the best place to ask, but I need to know.

nosnowowie93347 commented 4 years ago

and yes copypaste works

FlamingSharky commented 4 years ago

How do I get this to run on mac? I have wine and all but I don't know what file I use to open it

theoceanmytho commented 4 years ago

i dont use mac so i cant help you there. sorry

FlamingSharky commented 4 years ago

nah, i mean, what file do you use to run it, wine runs it as if i am on windows

FlamingSharky commented 4 years ago

Oh wait, sorry, just found the file lmao, ill report any bugs

FlamingSharky commented 4 years ago

Well, I can't run it apparently, any mac users that can help me out with this?

nosnowowie93347 commented 4 years ago

fix this @BinaryConstruct image

nosnowowie93347 commented 4 years ago

happens when importing schematic @BinaryConstruct

BinaryConstruct commented 4 years ago

@nosnowowie93347 Could you please attach the schematic file to a new issue?

atheran2 commented 4 years ago

While yesterday it was working fine for me, except the bug with placeable items (chests/pylons/etc) today it refuses to open the world I was playing yesterday. That happens both in beta 3 that I used yesterday and in beta 4 I just downloaded.

This is the error I get and it tells me to upload this. TEditLog.txt

That happens with multiple worlds I was able to open and edit yesterday. Ingame I can play fine without any issues and the weird thing is that I changed nothing between my last edit yesterday and trying to open the world today.

EDIT: That happens when I try to open the world file by double clicking on it (I have .wld ascociated with TEdit. If I open TEdit as admin beforehand and open the world by the menu it works fine. But it still won't open if I double click the world file afterwards. Which is confusing because yesterday it worked and I didn't change anything and it's not the update since it does the same on beta 3 I was running last night.

TLDR: It works but only if I open a world from TEdit menu, not from launching TEdit for opening .wld files.

BinaryConstruct commented 4 years ago

While yesterday it was working fine for me, except the bug with placeable items (chests/pylons/etc) today it refuses to open the world I was playing yesterday. That happens both in beta 3 that I used yesterday and in beta 4 I just downloaded.

This is the error I get and it tells me to upload this. TEditLog.txt

That happens with multiple worlds I was able to open and edit yesterday. Ingame I can play fine without any issues and the weird thing is that I changed nothing between my last edit yesterday and trying to open the world today.

EDIT: That happens when I try to open the world file by double clicking on it (I have .wld ascociated with TEdit. If I open TEdit as admin beforehand and open the world by the menu it works fine. But it still won't open if I double click the world file afterwards. Which is confusing because yesterday it worked and I didn't change anything and it's not the update since it does the same on beta 3 I was running last night.

TLDR: It works but only if I open a world from TEdit menu, not from launching TEdit for opening .wld files.

That message shows you are using TEdit 3.10.

atheran2 commented 4 years ago

@BinaryConstruct Now I feel like an idiot. I had ascociated .wld with TEdit before the update so it's probably still linked to that and not the updated version. Still can't understand why it worked yesterday tho', but anyways, it's not a problem with the current version.

nosnowowie93347 commented 4 years ago

@BinaryConstruct I feel like the remaining issues that need solving are going to be the most complex to solve

theoceanmytho commented 4 years ago

I agree, 1200 is imo the only one that truly needs priority, the offset sprites aren't really too offputting, and aside from the pylons, i'm fine with base images

IIVII17 commented 4 years ago

So I'm not sure what's gone wrong here. I've read the thread and it sounds like the saving issue was fixed by Beta 3, but when I try to load a world file using the latest beta, this error pops up. Additionally, when I do try to load the world file anyway and make changes, none of the changes are saved, and instead it's stuck on "Validating World..." no matter how big or small the changes were. Hoping there's a fix for this. TEdit Issue

theoceanmytho commented 4 years ago

I have no real clue on how to help you, do you use mods?

IIVII17 commented 4 years ago

I do not, no. The game was made in classic and Hardmode is enabled in the wld file, and as I said I am using the 4.0.0-beta4. Right now I don't know if I'm the only one getting this error and if maybe the problem is with my wld file, or if this is a known issue with beta4. I'll try removing that one hat rack and seeing if that changes anything.

IIVII17 commented 4 years ago

That was it. One stray hat rack placed in a jungle. Works perfectly fine after I tracked it down and annihilated it for the grief that it's caused me.

theoceanmytho commented 4 years ago

@BinaryConstruct Due to the recent bug fix update for terraria, is there any estimated release for an updated Tedit, or is that still unknown? Thanks in advance

Stardust1101 commented 4 years ago

The newly released beta 4 cannot function well on my computer. After saving using TEdit for any world, Terraria 1.4 itself cannot load the .wld file. On my computer, TEdit rendered sky (above ground level) as underground, I think it might be the problem.

fariasfrancisco commented 4 years ago

image

can't load world. Don't know if this helps.

Using beta 4

IIVII17 commented 4 years ago

@fariasfrancisco The last hotfix for Terraria (1.4.0.3) which was released today isn't compatible with Beta4 it seems. You can see that the TEdit Max World and Current World don't match from the error. I think that means your world file is currently newer than what Beta4 supports, so you might have to wait for Beta5 to release.

theoceanmytho commented 4 years ago

i have the same problem as sky, none of my changes save as well. Beta5 will probably have alot of fixes on it so i patiently wait

fariasfrancisco commented 4 years ago

Weird because I created the world when 1.4 rolled out. Or does it get updated whenever they release a hotfix?

On Thu, May 21, 2020, 10:21 IIVII17 notifications@github.com wrote:

@fariasfrancisco https://github.com/fariasfrancisco The last hotfix for Terraria (1.4.0.3) which was released today isn't compatible with Beta4 it seems. You can see that the TEdit Max World and Current World don't match from the error. I think that means your world file is currently newer than what Beta4 supports, so you might have to wait for Beta5 to release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TEdit/Terraria-Map-Editor/issues/1182#issuecomment-632082550, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVT7EYK32QF7LIE44B4HD3RSUTG3ANCNFSM4NDP43OA .

BinaryConstruct commented 4 years ago

The world files will always be the format of the game version that last played them. In fact you can even load up extremely old worlds in Terraria and they will instantly be upgraded to whatever game version you have installed.

nosnowowie93347 commented 4 years ago

@theoceanmytho @IIVII17 yes we do need to wait for Beta5. Beta4 is not compatible with 1.4.0.3

IIVII17 commented 4 years ago

I can confirm that the Beta5 that was released 2 hours ago works perfectly. Additionally, editing a wold file with TEdit no longer seems to break the pylons. Went in there to check if the world saved (it did), the pylons were perfectly fine (no longer needed to be broken and replaced). Thank you @BinaryConstruct !

nosnowowie93347 commented 4 years ago

yeah thanks. only a few issues left to fix

FlamingSharky commented 4 years ago

Nobody here uses mac for this?

theoceanmytho commented 4 years ago

As far as i am aware, no.

BinaryConstruct commented 4 years ago

Nobody here uses mac for this?

Mac support is only available through bootcamp or a VM.

tomek-i commented 4 years ago

The world files will always be the format of the game version that last played them. In fact you can even load up extremely old worlds in Terraria and they will instantly be upgraded to whatever game version you have installed.

Are you referring to the TEdit upgrade of worlds, in my PR I removed this to accomodate for iOS which was not at the same version as the other systems. it should be really optional to upgrade the world file within tedit or leave it as is and let terraria update it :)

theoceanmytho commented 4 years ago

I've encountered one of the strangest bugs i've seen amongst the betas, Everytime i save a modification that consists of the world failing to load, thus having to rely on it's backup, but while i was booting up tedit to get a new screenshot so i could demonstrate the changes i would make to explain the bug, i got this message: image @BinaryConstruct Apologies for the ping but i don't know whether this is a known bug or not, every change i make such as having an invasion cleared, causes my world on terraria to go to it's backup where it lacks those changes. Thanks in advance.

Xanokei commented 4 years ago

Adding or deleting liquids will cause the map to break after loading in terraria

JarOfTar commented 4 years ago

Trying to save a Large Master world after doing any edits would stop on Validating World, even after it runs for up to 10 minutes with seemingly no progression on the bar. Trying to use Save As would give me the same result. Before saving Tedit would warn me that the world had been modified by an external program, despite none running.

IIVII17 commented 4 years ago

@theoceanmytho I had the same error happen to me on Beta4, and it was because I had a hat rack in place with items in it. After breaking it, it worked fine. I think the same applies for weapon racks and mannequins. I don't know if this has been fixed in Beta5, so maybe try breaking them first?

theoceanmytho commented 4 years ago

That might actually be it, I'll make a copy and get rid of the mannequins and check if that works, thanks again.

BinaryConstruct commented 4 years ago

Beta6 has a huge amount of changes and some preliminary support for new TileEntities. Hat Racks and Mannequin are probably still broken. Weapon racks, item frames and plates should work.

nosnowowie93347 commented 4 years ago

@BinaryConstruct dont know if u knew this, but NPC sprites are duplicated. Heres an example: image

nosnowowie93347 commented 4 years ago

at the bottom of the image, see how the NPC sprites are duplicated? That's my issue

NathanAccurso commented 4 years ago

image Still getting this error on beta 6. I had a hat rack but deleted it in TEdit. Forcing the world to load results in a world that can't be loaded in Terraria. Should I delete the hat rack in game and try to load the world again?

theoceanmytho commented 4 years ago

Yeah, currently until #1200 is fixed we can't use said described items, you're best bet until the bug is fixed is to delete the hat rack and wait until whenever the patch is released that fixes it

BinaryConstruct commented 4 years ago

Today 5/24 marks the 9 birthday for TEdit. Hopefully Beta7 will save the worlds and it can become the 4.0 release.

atheran2 commented 4 years ago

So just to understand. Now pylons won't break? And I can have my items shown in display racks and mannequins, I just can't edit those in TEdit?

theoceanmytho commented 4 years ago

so just to verify, beta 7 will work with 1.4.0.4?

fakemanoan commented 4 years ago

Still getting "Validating World..." on beta 7 whilst attempting to save. Even if no changes have occurred. World is accessible in latest 1.4.0.4 update.

It's a large world generated on launch day. Other large world files generated do not have this issue. Attempting to analyse the world instantly crashes the program. If you like i can upload it for you because many seem to have this problem despite the world not being broken.

nosnowowie93347 commented 4 years ago

This can't be the last release you haven't fixed the sprites for NPCs and 1.4 items @BinaryConstruct