search

THI-Drone / mission_software_launch

Package used to launch all nodes required for Mission Software on the UAV.
MIT License
0 stars 0 forks source link

[IMPORTANT] No logs for Waypoint and QR Code scanner node #9

Closed Philipp66904 closed 3 months ago

Philipp66904 commented 3 months ago

In many of our flights during flight day 3, the log for the waypoint and qr code scanner node are completely empty.

Philipp66904 commented 3 months ago

The logs can be found here: https://drive.google.com/drive/folders/1-2gnSmibS07wBIrM6wb0Xbhact38qdht

Philipp66904 commented 3 months ago

@J0las @J0hn-Lawrence @di-math

Philipp66904 commented 3 months ago

And is it on purpose that we don't log DEBUG messages?

J0las commented 3 months ago

And is it on purpose that we don't log DEBUG messages?

No, this can´t be right. We need debug messages in the logs.

J0las commented 3 months ago

The logs can be found here: https://drive.google.com/drive/folders/1-2gnSmibS07wBIrM6wb0Xbhact38qdht

Do you have a specific folder this happened in?

J0las commented 3 months ago

At least in the current dev branch, the debug log level setting is commented out: https://github.com/THI-Drone/mission_software_launch/blob/37fa88a271cfc421fffa6081314fa58014b4f5ab/launch/launch.py#L59

J0las commented 3 months ago

Do we need a PR and approve flow here as well?

Philipp66904 commented 3 months ago

For example this one: https://drive.google.com/drive/folders/1gIfrk5p6EuIPCZ26kYghqS4K3qMkEg5n

Philipp66904 commented 3 months ago

Do we need a PR and approve flow here as well?

We had one: https://github.com/THI-Drone/mission_software_launch/pull/7

J0las commented 3 months ago

For example this one: https://drive.google.com/drive/folders/1gIfrk5p6EuIPCZ26kYghqS4K3qMkEg5n

Are we sure this isn´t an scp issue and the files on board are not empty?

J0las commented 3 months ago

Do we need a PR and approve flow here as well?

We had one: #7

Yeah, that one shouln´t have been merged

Philipp66904 commented 3 months ago

For example this one: https://drive.google.com/drive/folders/1gIfrk5p6EuIPCZ26kYghqS4K3qMkEg5n

Are we sure this isn´t an scp issue and the files on board are not empty?

No, we can't be sure about that. But the other files are looking fine and this is a rather consistent issue.

J0las commented 3 months ago

For example this one: https://drive.google.com/drive/folders/1gIfrk5p6EuIPCZ26kYghqS4K3qMkEg5n

Are we sure this isn´t an scp issue and the files on board are not empty?

No, we can't be sure about that. But the other files are looking fine and this is a rather consistent issue.

I would like to double check that, so that we are not hunting a phantom here while the issue lies somewhere else entirely

J0las commented 3 months ago

Does your mdf checker node use ros logs? @Philipp66904 Maybe you can set the env var and try if the log file is created even if there was no recorded log

Philipp66904 commented 3 months ago

Does your mdf checker node use ros logs? @Philipp66904 Maybe you can set the env var and try if the log file is created even if there was no recorded log

No, it doesn't. It's kept completely ROS free and therefore only uses printf. The final error message is inside the exception, though.

J0las commented 3 months ago

I just think it is strange why an empty log file would have been created. I would think it will be created upon the first log. Thats why I think the MDF checker would be a good canidate to test that, because it uses no ros logs

PhilipDelan commented 3 months ago

Updated launch file for UAV nodes

Note: This update is untested.

PhilipDelan commented 3 months ago

@incrazyboyy teste vielleicht mal ob die nodes alles starten in der sim

Philipp66904 commented 3 months ago

@incrazyboyy teste vielleicht mal ob die nodes alles starten in der sim

Bitte auch die Logs prüfen

Philipp66904 commented 3 months ago

Tested and seems to work now @PhilipDelan