Improve error handling in room

THM-Health / PILOS

PILOS is an easy-to-use open source front-end for BigBlueButton servers with a built-in load balancer. Docker-Images: https://hub.docker.com/r/pilos/pilos

https://thm-health.github.io/PILOS/

GNU Lesser General Public License v2.1

49 stars 18 forks source link

Improve error handling in room #1421

Closed SamuelWei closed 1 week ago

SamuelWei commented 1 week ago

Type (Highlight the corresponding type)

Bugfix
Feature
Documentation
Refactoring (e.g. Style updates, Test implementation, etc.)
Other (please describe):

Checklist

[ ] Code updated to current develop branch head
[ ] Passes CI checks
[ ] Is a part of an issue
[ ] Tests added for the bugfix or newly implemented feature, describe below why if not
[ ] Changelog is updated
[ ] Documentation of code and features exists

Changes

Handles 401 and 403 api errors in room components differently than in other parts of the application, causing a reload of the room and if required also a reload of the room tabs
Improve code to only reload room tab data if nesessary
Fix open modals of room tab items beeing dynamily assigned to other objects effecting data integrity
Refactor api composable structure
Improve current tab selection

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.33%. Comparing base (5fc6a58) to head (11c5700). Report is 2 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1421 +/- ## ============================================= - Coverage 95.35% 95.33% -0.03% Complexity 1323 1323 ============================================= Files 203 203 Lines 4583 4583 ============================================= - Hits 4370 4369 -1 - Misses 213 214 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 week ago

PILOS Run #682

Run Properties: Passed #682 • a8a98e983a: Improve error handling in room (#1421)

Project	`PILOS`
Branch Review	`develop`
Run status	`Passed #682`
Run duration	`03m 01s`
Commit	`a8a98e983a: Improve error handling in room (#1421)`
Committer	`Samuel Weirich`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`46`
View all changes introduced in this branch ↗︎