THM-Health / PILOS

PILOS is an easy-to-use open source front-end for BigBlueButton servers with a built-in load balancer. Docker-Images: https://hub.docker.com/r/pilos/pilos
https://thm-health.github.io/PILOS/
GNU Lesser General Public License v2.1
51 stars 19 forks source link

Fix missing error handling for 404 errors for personalized links actions #1561

Closed Sabr1n4W closed 1 week ago

Sabr1n4W commented 1 week ago

Fixes #1559

Type (Highlight the corresponding type)

Checklist

Changes

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.21%. Comparing base (c9e6b67) to head (4317c49). Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
.../components/RoomTabPersonalizedLinksEditButton.vue 0.00% 12 Missing :warning:
...omponents/RoomTabPersonalizedLinksDeleteButton.vue 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1561 +/- ## ============================================= - Coverage 75.32% 75.21% -0.12% Complexity 1322 1322 ============================================= Files 358 358 Lines 9120 9134 +14 Branches 844 845 +1 ============================================= Hits 6870 6870 - Misses 2250 2264 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 week ago

PILOS    Run #1044

Run Properties:  status check failed Failed #1044  •  git commit 5ba63f0e25: Fix missing error handling for 404 errors for personalized links actions (#1561)
Project PILOS
Branch Review develop
Run status status check failed Failed #1044
Run duration 03m 50s
Commit git commit 5ba63f0e25: Fix missing error handling for 404 errors for personalized links actions (#1561)
Committer Sabrina Wüst
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 177
View all changes introduced in this branch ↗︎


Tests for review

Failed  tests/Frontend/e2e/RoomsViewDescription.cy.js • 1 failed test • Frontend tests View Output
Test Artifacts
Rooms view description > edit description Test Replay Screenshots