THM-Health / PILOS

PILOS is an easy-to-use open source front-end for BigBlueButton servers with a built-in load balancer. Docker-Images: https://hub.docker.com/r/pilos/pilos
https://thm-health.github.io/PILOS/
GNU Lesser General Public License v2.1
51 stars 19 forks source link

[DX] Fix double negation on global API error handler option #1566

Closed SamuelWei closed 1 week ago

SamuelWei commented 1 week ago

Fixes #1557

Type (Highlight the corresponding type)

Checklist

Changes

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.22%. Comparing base (90a8074) to head (0a24583). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
resources/js/components/RoomTabHistory.vue 0.00% 1 Missing :warning:
...s/js/components/RoomTabHistoryAttendanceButton.vue 0.00% 1 Missing :warning:
...es/js/components/RoomTabHistoryStatisticButton.vue 0.00% 1 Missing :warning:
...sources/js/components/RoomTabPersonalizedLinks.vue 0.00% 1 Missing :warning:
...s/components/RoomTabPersonalizedLinksAddButton.vue 0.00% 1 Missing :warning:
...omponents/RoomTabPersonalizedLinksDeleteButton.vue 0.00% 1 Missing :warning:
.../components/RoomTabPersonalizedLinksEditButton.vue 0.00% 1 Missing :warning:
resources/js/components/RoomTabRecordings.vue 0.00% 1 Missing :warning:
...es/js/components/RoomTabRecordingsDeleteButton.vue 0.00% 1 Missing :warning:
...rces/js/components/RoomTabRecordingsEditButton.vue 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1566 +/- ## ========================================== Coverage 75.22% 75.22% Complexity 1322 1322 ========================================== Files 358 358 Lines 9139 9139 Branches 845 845 ========================================== Hits 6875 6875 Misses 2264 2264 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 week ago

PILOS    Run #1067

Run Properties:  status check passed Passed #1067  •  git commit 3932aa7f9f: (DX) Fix double negation on global API error handler option (#1566)
Project PILOS
Branch Review develop
Run status status check passed Passed #1067
Run duration 03m 59s
Commit git commit 3932aa7f9f: (DX) Fix double negation on global API error handler option (#1566)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 178
View all changes introduced in this branch ↗︎