THM-Health / PILOS

PILOS is an easy-to-use open source front-end for BigBlueButton servers with a built-in load balancer. Docker-Images: https://hub.docker.com/r/pilos/pilos

https://thm-health.github.io/PILOS/

GNU Lesser General Public License v2.1

51 stars 19 forks source link

Fix meeting start and server polling timing conflict #1608

Closed SamuelWei closed 11 hours ago

SamuelWei commented 11 hours ago

Fixes #1607

Type (Highlight the corresponding type)

Bugfix
Feature
Documentation
Refactoring (e.g. Style updates, Test implementation, etc.)
Other (please describe):

Checklist

[x] Code updated to current develop branch head
[x] Passes CI checks
[x] Is a part of an issue
[x] Tests added for the bugfix or newly implemented feature, describe below why if not
[x] Changelog is updated
[x] Documentation of code and features exists

Changes

Fix meeting marked as ended prematurely during starting phase of a new meeting
Add logging for server health changes
Add logging for detached meeting handling
Add logging for meeting not running on BBB server

codecov[bot] commented 11 hours ago

Files with missing lines	Patch %	Lines
app/Services/ServerService.php	85.71%	1 Missing :warning:

```diff @@ Coverage Diff @@ ## develop #1608 +/- ## ============================================= + Coverage 80.85% 80.93% +0.07% - Complexity 1322 1331 +9 ============================================= Files 359 359 Lines 9141 9182 +41 Branches 845 845 ============================================= + Hits 7391 7431 +40 - Misses 1750 1751 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

cypress[bot] commented 11 hours ago

PILOS Run #1149

Run Properties: Passed #1149 • d1216f001a: Fix meeting start and server polling timing conflict (#1608)

Project	`PILOS`
Branch Review	`develop`
Run status	`Passed #1149`
Run duration	`05m 15s`
Commit	`d1216f001a: Fix meeting start and server polling timing conflict (#1608)`
Committer	`Samuel Weirich`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`236`
View all changes introduced in this branch ↗︎