search

TIM-JYU / TIM

TIM (The Interactive Material) is an open-source cloud-based platform for creating interactive learning documents.
https://tim.education/view/about/en-US
MIT License
14 stars 4 forks source link

Liitteiden parannuksia - [merged] #2675

Closed dezhidki closed 2 years ago

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 16, 2019, 15:00

Merges 1377-popover-dialogiksi -> master

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 24, 2019, 14:15

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 26, 2019, 15:41

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 29, 2019, 13:29

added 29 commits

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 29, 2019, 15:50

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 29, 2019, 16:00

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 30, 2019, 13:41

added 10 commits

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 30, 2019, 14:56

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 2, 2019, 13:21

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 2, 2019, 13:25

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 2, 2019, 15:43

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 17

Nimessä Show on turha.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/upload/upload.py line 185

Käytä verify_json_params-funktion sijasta webargs-kirjastoa, ks. malli answer/routes.py ja sieltä /getState-reitti.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/upload/upload.py line 200

Tuo filePath lienee pikemminkin suhteellinen URL-osoite, joten voisiko sen nimi olla url?

Tässä voisi käyttää URLin parsintaa + PurePosixPathia, jolloin ainakaan tuota ensimmäistä replacea ei tarvitse.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/upload/upload.py line 205

Voisi olla

stamp_model_path = create_new_tex_file(custom_stamp_model_content) if custom_stamp_model_content else stamp_model_default_path

jolloin ulompaa if-elseä ei tarvitse.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/upload/upload.py line 217

Tämä try-except on liian laaja. Mielellään pois kokonaan.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/upload/upload.py line 202

Tähän silmukkaan oikeustarkistus, että tiedostoon tai siihen dokumenttiin, johon tiedosto on liitetty, on edit-oikeus.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 121

Näissä ng-show -> ng-if ja alertit tim-alert-komponentilla.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/util/pdftools.py line 663

Tuo get_path_base_filename on nykyään niin yksinkertainen funktio, että sen voisi poistaa ja sanoa suoraan .stem tai .name.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 102

Käytä tim-alert-komponenttia.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/document/minutes/routes.py line 86

Tässä replace-kutsujen sijaan mieluummin ast.literal_eval.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 933

Tämä on vanha rivi, mutta tuosta on jäänyt virke kesken.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1377

Tämä macroParams -> IAttachmentData -muunnos voisi olla omassa aliohjelmassaan, jotta nuo indeksoinnit ovat vain yhdessä paikassa.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1367

Plugineilla voi olla muitakin attribuutteja, jolloin tämä includes on liian tiukka. Jättäisin siis aaltosulut pois. Toki silloin se sallii myös xplugin tms., johon ehkä voisi regexillä varautua. Ainakaan sen monimutkaisempaa tästä ei kannattane tehdä ilman kunnon markdown-parsimiskirjastoa.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1362

Melkein koko metodi on tämän iffin sisällä, jolloin sisennyksiä tulee suotta lisää. Tämän voisi kääntää:

if (!this.editor) {
    return undefined;
}
// ja loput ilman elseä
dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1440

Käytä every-metodia nuolifunktion kera.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 3, 2019, 13:24

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 960

Hyvä dokumentaatiokommentti kun on selkeät esimerkit :thumbsup:. Jättäisin tyhjän rivin tämän alle esimerkkien erottamiseksi. Ja ehkä myös ennen ensimmäistä esimerkkiä.

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 13:29

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 17

Tuo oli jämä siitä, kun kopioin koodin toisesta dialogista pohjaksi. Siivoan sieltäkin sitten(?).

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:07

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 17

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/upload/upload.py line 200

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/upload/upload.py line 205

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/upload/upload.py line 217

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/upload/upload.py line 202

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 121

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/util/pdftools.py line 663

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 102

changed this line in version 12 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:23

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:29

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:34

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 3, 2019, 15:34

added 14 commits

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 13:06

Commented on timApp/document/minutes/routes.py line 86

changed this line in version 16 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 13:06

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:32

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 933

changed this line in version 17 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:32

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1377

changed this line in version 17 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:32

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1367

changed this line in version 17 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:32

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1362

changed this line in version 17 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:32

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:33

added 14 commits

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:45

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 14:50

added 1 commit

Compare with previous version