search

TIM-JYU / TIM

TIM (The Interactive Material) is an open-source cloud-based platform for creating interactive learning documents.
https://tim.education/view/about/en-US
MIT License
14 stars 4 forks source link

Liitteiden parannuksia - [merged] #2675

Closed dezhidki closed 2 years ago

dezhidki commented 5 years ago

In GitLab by @vivanauk on Apr 16, 2019, 15:00

Merges 1377-popover-dialogiksi -> master

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 15:22

resolved all discussions

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 15:22

Commented on timApp/upload/upload.py line 185

changed this line in version 21 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 6, 2019, 15:22

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 7, 2019, 15:34

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 7, 2019, 15:49

added 2 commits

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/document/viewctrl.ts line 663

Tämä lienee nyt käyttämätön.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/document/viewctrl.ts line 40

Käyttämätön import.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 151

Muuta tässä macros -> macros?, koska sitä ei välttämättä ole. Silloin getCurrentMeetingDaten voi tehdä ilman try-catchia korjaamalla tyyppivirheet.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/upload/upload.py line 309

str-muunnos taitaa tapahtua f-merkkijonoissa automaattisesti.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 864

Tämä voisi olla await to(showRestampDialog(...)), jolloin otetaan huomioon myös dialogin sulkeminen ruksista.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 873

Muuta every -> forEach. everyllä on tarkoitus vain testata, päteekö jokin ehto kaikille.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 870

.valueOf()-kutsut on turhia.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 877

.valueOf()-kutsut on turhia.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 1358

Tosiaan tämän try-catchin saa pois, kunhan tekee sen toisessa kommentissa mainitun muutoksen tuohon docSettingsin tyyppiin.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 8, 2019, 11:55

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 832

Tämän true-sijoituksen voisi varmaan siirtää ylemmäksi ennen iffiä.

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:02

Commented on timApp/static/scripts/tim/document/viewctrl.ts line 663

changed this line in version 24 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:02

Commented on timApp/static/scripts/tim/document/viewctrl.ts line 40

changed this line in version 24 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:02

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 151

changed this line in version 24 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:02

added 3 commits

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:21

resolved all discussions

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:45

Commented on timApp/upload/upload.py line 309

changed this line in version 25 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:45

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 864

changed this line in version 25 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:45

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 873

changed this line in version 25 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:45

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 870

changed this line in version 25 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:45

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 877

changed this line in version 25 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:45

Commented on timApp/static/scripts/tim/editor/pareditor.ts line 832

changed this line in version 25 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 8, 2019, 14:45

added 2 commits

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 9, 2019, 14:09

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 9, 2019, 14:17

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 9, 2019, 14:41

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 11

Turha import.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/userMenu.ts line 6

Turha import.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 79

Nämä super-kutsut mielellään aina ensimmäisenä.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 93

Otsikoksi Add a user to this session, jos ollaan addingToSession-tilassa, niin menee samalla tavalla kuin tuotannossa.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 100

Tämä lienee käyttämätön.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 109

Tämä lienee käyttämätön.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 120

Tämä lienee käyttämätön.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/userMenu.ts line 31

Tämän addingToSession-attribuutin voi poistaa ja tässä voi viedä aina true toisena parametrina.

Silloin kutsu tosin näyttää tältä:

void showLoginDialog(false, true);

ja on hankala muistaa, mitä nuo arvot tarkoittavat. Muuta niin, että showLoginDialog saa yhden parametrin ILoginParams, jolloin kutsut ovat selkeämpiä kun niihin tulee nimet näkyviin.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 145

Tämä lienee käyttämätön.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 95

Tämä lienee käyttämätön.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:05

Commented on timApp/static/scripts/tim/frontpage/startController.ts line 99

Nämä 2 metodia ovat lähes samat.

dezhidki commented 5 years ago

In GitLab by @Smibu on May 10, 2019, 12:07

Heitin vielä viimeiset kommentit. GitLabkin näyttää vihreää, joten kommenttien ja rebasen jälkeen tämän voisi mergetä.

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:01

added 1 commit

Compare with previous version

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:14

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 79

Jostain syystä dialogin parametreista saatavat addingToSession ja showSignup menevät väärin jos super on ensimmäisenä.

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/editor/restampDialog.ts line 11

changed this line in version 30 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/userMenu.ts line 6

changed this line in version 30 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 79

changed this line in version 30 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 100

changed this line in version 30 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 109

changed this line in version 30 of the diff

dezhidki commented 5 years ago

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 120

changed this line in version 30 of the diff