Liitteiden parannuksia - [merged]

[dezhidki]

In GitLab by @vivanauk on Apr 16, 2019, 15:00

Merges 1377-popover-dialogiksi -> master

[dezhidki]

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/userMenu.ts line 31

changed this line in version 30 of the diff

[dezhidki]

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 145

changed this line in version 30 of the diff

[dezhidki]

In GitLab by @vivanauk on May 10, 2019, 13:57

Commented on timApp/static/scripts/tim/user/loginDialog.ts line 95

changed this line in version 30 of the diff

[dezhidki]

In GitLab by @vivanauk on May 10, 2019, 13:57

added 1 commit

• fbefb6ab - Address review comments

Compare with previous version

[dezhidki]

In GitLab by @vivanauk on May 10, 2019, 13:58

resolved all discussions

[dezhidki]

In GitLab by @vivanauk on May 10, 2019, 14:08

added 1 commit

• 44171930 - Update comments and fix bug in opening the login dialog

Compare with previous version

[dezhidki]

In GitLab by @vivanauk on May 10, 2019, 14:13

added 32 commits

• 44171930...523d8eda - 3 commits from branch master
• df0c4c7a - Add a check for attachments when deciding upload link format
• a64eacff - Add better check for bounds of attachment macros
• 2a6608ed - Add checks for changes in attachment macros and warn when saving
• 62c9845c - Fix attachment check in onInit
• 979d94bd - Add restamp dialog
• 3624874f - Accept value in parentheses and with spaces when parsing extract index
• 27078516 - Add restamping route
• 02f365da - Add parent check option to edit access verification
• 8242e1d7 - Address review comments
• 7afa4456 - Fix pdf merging
• 933c769d - Change dialog UI
• bf6174a0 - Use literal evaluation instead to parse extract index
• f2851441 - Add better handling when user returns from restamp dialog
• c073c0a0 - Add error handling when restamping non-existent file
• d2c72856 - Add handling when restamping fails and user returns to editor
• 8c2f933d - Use webargs when getting restamp parameters
• 5eb4c026 - Separate login and user menu and open them as dialogs
• 656741c3 - Remove unnecessary file
• 84844f9b - Add missing buttons and fix sign up showing wrong title
• b953fc71 - Update comments
• ba9f7680 - Add existence checks for macros in docSettings
• 9e03db64 - Remove unused methods and variables
• 79a98a15 - Add dismiss handling to restamp dialog
• e0f5a360 - Address review comments
• d509e566 - Add user menu component and remove user menu dialog
• 86b6ed82 - Update tests
• a889e97b - Allow only one login dialog at a time
• 4313f684 - Address review comments
• c19bc6f8 - Update comments and fix bug in opening the login dialog

Compare with previous version

[dezhidki]

In GitLab by @Smibu on May 10, 2019, 14:44

unmarked as a Work In Progress

[dezhidki]

In GitLab by @Smibu on May 10, 2019, 14:44

approved this merge request

[dezhidki]

In GitLab by @Smibu on May 10, 2019, 14:44

merged