feat: add roles "system" and "chrony"

TOSIT-IO / tdp-collection-prerequisites

Ansible collection with TDP prerequisites

Apache License 2.0

3 stars 10 forks source link

feat: add roles "system" and "chrony" #1

Closed rpignolet closed 2 years ago

rpignolet commented 2 years ago

system role configure /etc/hosts, yum package and pip3 dependencies.

Which issue(s) this PR fixes:

Fixes #2 #3

Additional comments:

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 and that you give permission to TOSIT, you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

Nuttymoon commented 2 years ago

Shouldn't this collection be compatible with tdp-lib with tdp_lib_dag and tdp_vars_defaults so that deployments can be managed easily?

rpignolet commented 2 years ago

Shouldn't this collection be compatible with tdp-lib with tdp_lib_dag and tdp_vars_defaults so that deployments can be managed easily?

This collection can be compatible with tdp-lib DAG but do we want to do prerequisites with the DAG ? This will add complexity to maintain and for now we can not add dependencies to existing components without redefine it.

Nuttymoon commented 2 years ago

Shouldn't this collection be compatible with tdp-lib with tdp_lib_dag and tdp_vars_defaults so that deployments can be managed easily?

This collection can be compatible with tdp-lib DAG but do we want to do prerequisites with the DAG ? This will add complexity to maintain and for now we can not add dependencies to existing components without redefine it.

I guess that services within this collection could have dependencies on each other.

gboutry commented 2 years ago

Shouldn't this collection be compatible with tdp-lib with tdp_lib_dag and tdp_vars_defaults so that deployments can be managed easily?

This collection can be compatible with tdp-lib DAG but do we want to do prerequisites with the DAG ? This will add complexity to maintain and for now we can not add dependencies to existing components without redefine it.

I guess that services within this collection could have dependencies on each other.

In my opinion, prerequisites are moved to clear tdp-getting-started and be shown as an example, but they are not meant to be managed as a TDP service.

I'm against adding tdp_lib_dag and tdp_vars_defaults

Nuttymoon commented 2 years ago

I am just concerned about the impact on tdp-getting-started's accessibility if we use some collections that are not tdp-lib compatible. This means that users will have to use both ansible-playbook and tdp XXX commands, and the tdp-getting-started file structure will be more complicated than if it was relying on playbooks/meta + tdp_lib_dag for all collections.

leopaul36 commented 2 years ago

I am just concerned about the impact on tdp-getting-started's accessibility if we use some collections that are not tdp-lib compatible. This means that users will have to use both ansible-playbook and tdp XXX commands, and the tdp-getting-started file structure will be more complicated than if it was relying on playbooks/meta + tdp_lib_dag for all collections.

IMO this should not be an issue if our documentation states clearly what is in the TDP scope (ie: managed by tdp) and what isn't. We should make it very clear that we don't support the pre-requisites roles and that they are proposed as is as a way to get started more easily. Just like the Vagrant role is offered to get started on local, VMs, etc.

Thus I agree with @rpignolet and @gboutry

Nuttymoon commented 2 years ago

Works for me.