TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
183 stars 42 forks source link

playlist scroll pos #1120

Closed mono424 closed 11 months ago

mono424 commented 1 year ago

Motivation and Context

If the playlist sidebar is not visible on page start, the scroll position is not set to the active item.

https://github.com/TUM-Dev/gocast/assets/17506411/ab908c9c-60e0-4656-8336-c8e4f9803a56

Description

This pr adds a observer that scrolls to the right position upon sidebar open.

Steps for Testing

Prerequisites:

  1. Log in
  2. Navigate to a Livestream
  3. Check if its scrolled to the right item if you open the playlist sidebar

Screenshots

https://github.com/TUM-Dev/gocast/assets/17506411/f96f7a1a-ed2c-472e-a974-6197e7dd8f89

github-actions[bot] commented 1 year ago

Your Testserver will be ready at https://1120.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
joschahenningsen commented 11 months ago

What's the status of this? @mono424

mono424 commented 11 months ago

What's the status of this? @mono424

Its ready to get reviewed :)