search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
183 stars 42 forks source link

Prolong maximum chat message length to 1000 characters #1135

Closed JosefSchoenberger closed 1 year ago

JosefSchoenberger commented 1 year ago

Motivation and Context

We want longer chat messages! I can't answer to the questions of our students if I'm not able to write a long prose with at least 800 characters! :-P Resolves #778.

Description

I replaced the chat input box with a multiline text area and extended the maximum message length from 200 to 1000 characters.

Steps for Testing

  1. Log in
  2. Find a stream or VOD you can comment on
  3. Write a long text message with more then 200 characters. May include multiple lines with Shift+Enter.
joschahenningsen commented 1 year ago

BTW, there also is server side validation: https://github.com/joschahenningsen/TUM-Live/blob/dev/model/chat.go#L40

JosefSchoenberger commented 1 year ago

Alright, thanks – I was already wondering, but the server accepted messages with ~220 characters and did not find any other occurence of "200" related to chat messages, so I assumed there was no server-side check. Btw., was there a reason for why the server-side limit was higher?

joschahenningsen commented 1 year ago

Btw., was there a reason for why the server-side limit was higher?

I can't think of any reason why we would have done this on purpose. I assume it was just an oversight.