search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
180 stars 42 forks source link

Course setting cannot be saved #1178

Closed bernhard0309 closed 10 months ago

bernhard0309 commented 10 months ago

Describe the bug "Save Settings" Button for Course Settings does not work To Reproduce Steps to reproduce the behavior:

  1. Go to 'Settings"
  2. Change Visibility of this course
  3. Click "Save Settings"
  4. Reload page
  5. -> Visibility of this course is not changed

Expected behavior Save new selected visibility of course

Desktop (please complete the following information): Windows 10, Edge or Firefox

alexanderstephan commented 10 months ago

Seems to be due to the rename of a function: image

alexanderstephan commented 10 months ago

Cannot reproduce locally with latest dev.

joschahenningsen commented 10 months ago

ee92bd6685851090ef2a5660b53ecdf87eb6c5ba is currently deployed. Maybe this issue only affects lectures with chat enabled?

joschahenningsen commented 10 months ago

@mono424 was this possibly introduced in #1137?

mono424 commented 10 months ago

Could be, I tested again with the new Settings PRs, can we merge? Pretty sure this should fix it already :)

joschahenningsen commented 10 months ago

1156?