TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
180 stars 42 forks source link

1175 course import dont ask to leave page all the time #1198

Closed DawinYurtseven closed 8 months ago

DawinYurtseven commented 9 months ago

What was the problem:

The problem was that each time something happened during a Course Import, the browser would ask the user if they wanted to leave the page, which would lead to a refreshed site and no changes saved.

What caused it:

there where two reasons why this happened.

My Fixes:

github-actions[bot] commented 9 months ago

Your Testserver will be ready at https://1198.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
SebiWrn commented 9 months ago

Maybe you can add back the two comments to preventDefault() and returnValue that have been there before so we know why these two commands are there