search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
178 stars 42 forks source link

1214 playback at t 0 #1224

Closed YiranDuan721 closed 8 months ago

YiranDuan721 commented 8 months ago

Motivation and Context

fixed #1214

Description

Distinguish the behavior of the watchProgress function when the parameter t is set to 0 and when it is not set, so that it matches the description in the comment:

If query parameter 't' is specified, the timestamp given by 't' will be used.

Steps for Testing

  1. Clear website cache
  2. Log in
  3. Navigate to a recording video
  4. Jump to anywhere in the video other than the start
  5. Refresh the page, note that the watch progress has been recorded and can be restored, so that the video resumes at the last progress
  6. Add parameter "t=0" to current url and visit it
  7. See the video plays from the start
github-actions[bot] commented 8 months ago

Your Testserver will be ready at https://1224.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
YiranDuan721 commented 8 months ago

Thanks for the review! I can't find a way to revert the change to "go.work.sum" file elegantly -- I'll just create a new branch and do the things again. Sorry for the bother, I'll be more careful with git next time. :pingubonk: