search

TUM-Dev / gocast

TUMs lecture streaming service.
https://tum.live
MIT License
186 stars 42 forks source link

Incorrect behaviour of bookmarks during streaming #1243

Open YiranDuan721 opened 10 months ago

YiranDuan721 commented 10 months ago

Describe the bug The default timestamp for bookmarks added during streaming is incorrect; in beta stream, the positions of the bookmarks displayed on the play progress slide bar are incorrect.

1. Incorrect default timestamp of new bookmarks created during streaming (alpha)

To Reproduce Steps to reproduce the behavior:

  1. Go to whatever live stream, turn beta stream OFF
  2. Add a bookmark
  3. Notice that the default timestamp of the new bookmark is the time since the stream has been played in current tab

Expected behavior The default timestamp of new bookmarks should be the time since its scheduled starting time.

2. Incorrect default timestamp of new bookmarks created during streaming (beta)

To Reproduce Steps to reproduce the behavior:

  1. Go to whatever live stream, turn beta stream ON
  2. Add a bookmark
  3. Notice that the default timestamp of the new bookmark is the current play progress

Expected behavior The default timestamp of new bookmarks should be the time since its scheduled starting time.

3. Incorrect position of bookmarks on the play progress slide bar during streaming (beta)

To Reproduce Steps to reproduce the behavior:

  1. Go to whatever live stream, turn beta stream ON
  2. Add multiple bookmarks
  3. Notice that on the play progress slide bar, all bookmarks are positioned at the very beginning

Expected behavior The bookmarks should be positioned according to their timestamps.

Screen shot