search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
178 stars 42 forks source link

Seeking with playback rates != 1.0x seeks inappropriate amounts of real time #1252

Open MariusAlbrecht opened 7 months ago

MariusAlbrecht commented 7 months ago

Describe the bug Seeking moves 15 seconds in the player. The actual time passed in the recording however depends on the playback rate. This leads to people watching on rates != 1 (especially those higher) to seek forward/backwards inappropriate amounts of real time. For me, e.g., the default seek behavior moves far more than half of a minute (with playback rates >= 2.4) of real time which is pretty useless most times.

To Reproduce Steps to reproduce the behavior:

  1. play a stream

Expected behavior always seek (roughly) the same real time and thus seek only seek_time / playback_rate seconds in the player. I feel like this issue can not be fixed with just #1171 #1234 because that'd require a permanent playback rate

YiranDuan721 commented 7 months ago

Hi! Thanks for the issue. I'm not sure, by "real time", do you mean the duration of the video, or the time in the real world (so for a 1-minute-long video with 2x playback rate, the real time would be 30 seconds)? If it's the former one (duration of the video), I didn't manage to reproduce the problem; For the latter one, I personally think that the current seek behaviour is more natural