TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
178 stars 42 forks source link

popupContext ws subscription is added. #1253

Closed barisgul15 closed 7 months ago

barisgul15 commented 7 months ago

Motivation and Context

Fixes the issue Popup chat does not update #1199

Description

When pop-up chat is opened, a new web socket(ws) is created so that the new chat can work properly. When examined, the only difference between normal-chat(chat near video) and popup chat is that, normal chat subscribes a void handler when created, but popup chat does not do that. As a solution, a void handler is created on popup.ts and the web socket subscribed via this handler and popup chat started working.

Steps for Testing

Prerequisites:

  1. Log in
  2. Create a course and enable chat
  3. Create a lecture and open the chats lecture
  4. Open the popup chat and test sendin messages in both chats and check whether both checks are updated accordingly.

Screenshots

github-actions[bot] commented 7 months ago

Your Testserver will be ready at https://1253.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
alexanderstephan commented 7 months ago

@meandaD If it is okay for you, I would merge it as it is to avoid further delays. Feel free to press merge yourself.

YiranDuan721 commented 7 months ago

Awesome! 🎉 A surprisingly simple fix. I would like to merge and deploy this as soon as possible, so we can use it in the lecture on Wednesday.

I don't really mind the comments.

I gree with this