search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
178 stars 42 forks source link

Share dialog should be quittable with 'esc' #1255

Closed MariusAlbrecht closed 6 months ago

MariusAlbrecht commented 7 months ago

Is your feature request related to a problem? Please describe. only quittable by clicking the 'x' or outside of the popup. This makes mouse action neccesary and feels unnatural (for me. I basically click 'esc', realise it doesnt work and then use my mouse)

Describe the solution you'd like also make 'esc' close the popup

barisgul15 commented 6 months ago

I just implemented this, because it also makes sense for me, but if you click outside anywhere on the tab on share dialog, it would also close the popup.

MariusAlbrecht commented 6 months ago

I personally think that makes sense.