search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

1255 share dialog should be quittable with esc #1270

Closed barisgul15 closed 6 months ago

barisgul15 commented 6 months ago

Motivation and Context

Fixes the issue: #1255

Description

The eventlistener function to close the popup chat when esc is pressed is added to popup.ts and called in popup chat's html file.

Steps for Testing

Prerequisites:

  1. Log in
  2. Create a course with chat enabled or navigate to a course for which chat is enabled.
  3. Open popup chat and press esc to quit the popup chat tab.

Screenshots

github-actions[bot] commented 6 months ago

Your Testserver will be ready at https://1270.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
SebiWrn commented 6 months ago

Your code is working, but I think it doesn't solve the Issue mentioned in your PR. I think the Issue meant, that the share button at the bottom of a livestream, where you can share the current stream URL is not quittable with ESC.

barisgul15 commented 6 months ago

Your code is working, but I think it doesn't solve the Issue mentioned in your PR. I think the Issue meant, that the share button at the bottom of a livestream, where you can share the current stream URL is not quittable with ESC.

Thanks for the feedback. When I saw popup, my mind immediately went to the chat but yeap, it was about something else.