search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

Revise golangci-lint configuration #1274

Closed alexanderstephan closed 6 months ago

alexanderstephan commented 6 months ago

Motivation and Context

Previously, the linter started linting starting from the moving branch HEAD. Of course, this is always the latest commit, rendering the linter ineffective.

Description

Update the golangci configuration to mitigate this problem. Besides, I remove depguard as it seems a bit over the top. We now actually only highlight new issues now, i.e., issues that will come on top of dev. Feel free to run it locally on older changes to find meaningful issues.

Steps for Testing

None. A passing CI should be enough.

github-actions[bot] commented 6 months ago

Your Testserver will be ready at https://1274.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
alexanderstephan commented 6 months ago

The issues somehow differ from what I am seeing locally, investigating...

alexanderstephan commented 6 months ago

Works as it should now. 🎉