search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

popup chat close on esc added. #1281

Closed barisgul15 closed 6 months ago

barisgul15 commented 6 months ago

Motivation and Context

closes #1280

Description

add an event listener so that popup chat is closed when esc is clicked

Steps for Testing

Prerequisites:

  1. Log in
  2. Navigate to a lecture recording with chat enabled or create one
  3. Open popup chat and click esc and check whether it closes the popup chat browser or not

Screenshots

github-actions[bot] commented 6 months ago

Your Testserver will be ready at https://1281.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
alexanderstephan commented 6 months ago

I think that this is a convenient feature. 👍 But we should document that shortcut somewhere, right? Maybe we could have a couple other shortcuts here which are then explained in a small dialog box. I imagine a small icon with a keyboard logo. It could be a component that we could reuse on other parts of the website where we use shortcuts.

alexanderstephan commented 6 months ago

Maybe one other note. Commit messages should not end with a dot (.) and use sentence case.

barisgul15 commented 6 months ago

I think that this is a convenient feature. 👍 But we should document that shortcut somewhere, right? Maybe we could have a couple other shortcuts here which are then explained in a small dialog box. I imagine a small icon with a keyboard logo. It could be a component that we could reuse on other parts of the website where we use shortcuts.

While implementing that I was also asking myself how will user gonna know that popup chat can be closed by pressing esc but could not think of a convenient idea. I think your suggestion makes sense. If its ok for you, I can create a new issue about it and work on it?