TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

Showing shortcuts on keyboard for relevant pages #1289

Open barisgul15 opened 6 months ago

barisgul15 commented 6 months ago

Is your feature request related to a problem? Please describe. There are some shortcuts on tumlive, which aims to make user experience easier. However since these are not documented in a way that users can reach easily, they may be not used as expected. A general documentation is planned as we have spoken in the meetings, but this also targets mostly lecturers and even if a documentation for students is also added, as I am also a student, I think a more easier way for students will be used much more.

Describe the solution you'd like As @alexanderstephan mentioned in #1281 here, a small keyboard logo can be added to relevant pages and when clicked, can show the shortcuts relevant. Additionally/Or depending on the shortcuts, that button can also be added in the settings page or an image showing the relevant shortcuts on keyboard can be added.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

MariusAlbrecht commented 6 months ago

I suggest doing it like youtube: shortcut on button hover image overview in menu at the top (which could perfectly be the hamburger menu for us) image image

Also, I personally don't think trivial or customisable keybinds need documentation. Afaict the only keybinds present are basic media control ones and 'Esc' to close popups, these seem trivial to me.

barisgul15 commented 5 months ago

These suggestions really make sense and thats what I will implement

goodstuff20 commented 3 months ago

It would be good if keyboard shortcuts could be customizable as well, especially since many students already use chrome extensions for video playback (slower,faster, skip...)