TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

1275 description markdown rendering not working #1297

Closed YiranDuan721 closed 5 months ago

YiranDuan721 commented 5 months ago

Todos

Screenshots

Before:

image image

After:

image image

github-actions[bot] commented 5 months ago

Your Testserver will be ready at https://1297.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |
SebiWrn commented 5 months ago

I think there is still a bug if you have a big description: This is what it looks like with many lines in markdown: image

I think the description should be way smaller and extend if you press "show more"

YiranDuan721 commented 5 months ago

I think there is still a bug if you have a big description: This is what it looks like with many lines in markdown: image

I think the description should be way smaller and extend if you press "show more"

Thank you for testing! I think this is because currently whether or not to collapse a long description is based on the total number of characters, not the number of lines. I will fix this further today (hopefully).

YiranDuan721 commented 5 months ago

I think there is still a bug if you have a big description: This is what it looks like with many lines in markdown: image

I think the description should be way smaller and extend if you press "show more"

This problem should have been resolved in the new commits.